Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zypper, xbps (Void Linux) to apx, fix export bin #80

Merged
merged 7 commits into from
Jan 26, 2023

Conversation

kbdharun
Copy link
Member

@kbdharun kbdharun commented Jan 22, 2023

Changes

  • Added openSUSE (zypper) flag to apx.
  • Added Void (Linux) [xbps] flag to apx.
  • Fixed export --bin.

Issues

  • apx export --bin doesn't work with Void. [But all other commands work as expected], Fixed by @matbme.
  • autoremove subcommand isn't present in zypper. [So it is marked as not implemented]

Related PRs

Vanilla-OS/vanilla-control-center#96

Related Images

neofetch in void container

Fig. Neofetch in Void (Linux) container [Renamed to xbps]

neofetch in openSUSE container

Fig. Neofetch in openSUSE container

Tests run

  • All commands has been tested (by running go build and executing the binary) and works as expected and issues encountered are listed above.

@kbdharun kbdharun changed the title Add Zypper to apx Add Zypper, Void Linux to apx Jan 22, 2023
@kbdharun kbdharun marked this pull request as draft January 22, 2023 13:07
@kbdharun kbdharun marked this pull request as ready for review January 22, 2023 13:36
@kbdharun kbdharun changed the title Add Zypper, Void Linux to apx Add Zypper, xbps (Void Linux) to apx Jan 22, 2023
@matbme
Copy link
Member

matbme commented Jan 22, 2023

apx export --bin doesn't work in void because the terminal path returned by $(getent passwd $USER | cut -f 7 -d :) isn't the same as other containers. While Arch, for example, returns /usr/bin/zsh, Void returns /usr/sbin/zsh, which causes the distrobox-host-exec command to fail

@kbdharun kbdharun changed the title Add Zypper, xbps (Void Linux) to apx Add zypper, xbps (Void Linux) to apx Jan 23, 2023
@kbdharun kbdharun changed the title Add zypper, xbps (Void Linux) to apx Add zypper, xbps (Void Linux) to apx, fix export bin Jan 23, 2023
@mirkobrombin mirkobrombin merged commit 2ddedeb into Vanilla-OS:main Jan 26, 2023
@kbdharun kbdharun deleted the zypper branch January 26, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants