Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat [close #50, #54] Several fixes #71

Merged
merged 6 commits into from
Dec 17, 2023
Merged

feat [close #50, #54] Several fixes #71

merged 6 commits into from
Dec 17, 2023

Conversation

matbme
Copy link
Member

@matbme matbme commented Dec 16, 2023 •
edited
Loading

This PR fixes several issues with VSO, related to missing translation placeholders, (un)export, run commands with flags, etc.

Fixes #50, #54

kbdharun
kbdharun approved these changes Dec 16, 2023
View reviewed changes
Copy link
Member

@kbdharun kbdharun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fixes.

Edit: To prevent conflicts I will push all changes and lock the VSO component on Weblate.

Update: Done the component is locked now and I have merged the translations.

@matbme matbme merged commit 254b36d into main Dec 17, 2023
3 checks passed
@matbme matbme mentioned this pull request Dec 17, 2023
Closed
@kbdharun kbdharun deleted the feat/fixes branch December 17, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirkobrombin mirkobrombin mirkobrombin approved these changes

@kbdharun kbdharun kbdharun approved these changes

@axtloss axtloss axtloss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VSO Doesn't Accept Command Args
4 participants
@matbme @mirkobrombin @kbdharun @axtloss