Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds mailcatcher support. #632

Merged

Conversation

EHLOVader
Copy link
Contributor

This PR replaces #464

This is based off of the develop branch and should be used instead.

Includes:
RVM install
mailcatcher install
startup script
PHP smtp configuration
dashboard link to port

Later revisions also did the following:
Fixes issues with signature checks in the RVM installation process.
Removed the stopgap fix for i18n dependency issues of past.
Added blank lines per request.

@dwainm
Copy link

dwainm commented Apr 28, 2015

@EHLOVader this branch works. Thanks for all the effort, kudos to you. I hope it gets into master soon.

@jdevalk
Copy link
Contributor

jdevalk commented Apr 28, 2015

Works like a charm. Great work @EHLOVader, please merge @jeremyfelt :)

@hlashbrooke
Copy link

+1 to this - would love to see this in master soon :)

@cfoellmann
Copy link
Member

@EHLOVader please edit your main comment and add Close #337 so it will close #337 automatically on merge

@cfoellmann
Copy link
Member

👍 for merge

@tacoverdo
Copy link

👍

Close Varying-Vagrant-Vagrants#337
Close Varying-Vagrant-Vagrants#464 past PR based on master

Includes:
 RVM install
 mailcatcher install
 startup script
 PHP smtp configuration
 dashboard link to port

Later revisions also did the following:
Fixes issues with signature checks in the RVM installation process.
Removed the stopgap fix for i18n dependency issues of past.
Added blank lines per request.
@jeremyfelt jeremyfelt added this to the 1.3.0 (Next Release) milestone May 17, 2015
@jeremyfelt
Copy link
Member

Thanks for all the great work @EHLOVader! And thanks to everyone for testing this out here and in #464. :)

Things seem to be working great after provisioning. I started with a fresh VM on develop and then did vagrant provision with this pull request applied. It added about 5 minutes because of the extra Ruby download, but that's not too bad. It would be nice to find a way to speed it up in the future if possible.

After merge I'm going to play with a few things:

  • Attempt to silence the gem install that (I think) is generating the ruby download messaging. Because of how Vagrant displays the messaging, this creates a wall of red. Though silencing will create a wall of silence. We'll see. :)
  • Look into what binding to 0.0.0.0 implies. It would be nice if we could bind to a specific address to avoid possible security issues, especially if someone has converted their box to a public IP for use with external testing.
  • We're doing version detecting in a few places now for a couple things. We should be able to abstract this as a separate function to clean up provision.sh a bit.

jeremyfelt added a commit that referenced this pull request May 17, 2015
@jeremyfelt jeremyfelt merged commit 0adb978 into Varying-Vagrant-Vagrants:develop May 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants