Module 'purchase_requisition_line_analytic' should not really depend on 'account_analytic_plans' #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on module 'account_analytic_plans' but on 'analytic'.
|
@hbto Can you send me a +1 please. I think @jbeficent has a point here. @jbeficent can you complement this mp with the second module that you are commenting in order to make only one merge with the split, please. |
|
@nhomar Module 'purchase_requisition_line_analytic_plan' that I was not mentioning really does not exist. I was just pointing out that it would need to be created, if needed, instead of adding the dependency of 'account_analytic_plans' in 'purchase_requisition_line_analytic'. |
…o that a user following a requisition can view the requisition that he follows.
|
@moylop260 Can you review this one also? |
|
@jbeficent Two changes LGTM. |
moylop260
added a commit
that referenced
this pull request
Feb 18, 2015
Module 'purchase_requisition_line_analytic' should not really depend on 'account_analytic_plans'
moylop260
added a commit
to vauxoo-dev/addons-vauxoo
that referenced
this pull request
Feb 18, 2015
Module 'purchase_requisition_line_analytic' should not really depend on 'account_analytic_plans'
moylop260
added a commit
that referenced
this pull request
Feb 18, 2015
Merge pull request #44 from Eficent/7.0
|
@jbeficent |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should only depend on 'account_analytic'. The dependence on 'account_analytic_plans' installs this module, which can be a problem for companies that really don't use it.
If purchase requisitions should really make use of analytic plans, then I suggest a new module on top of the existing called 'purchase_requisition_line_analytic_plan'.
Regards,
Jordi.