Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vector call linking with trigonometric functions #274

Merged
merged 2 commits into from
Jun 22, 2021
Merged

Fix vector call linking with trigonometric functions #274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41a3345
add msvs 2019 build files to gitignore
EricAtORS Apr 24, 2021
9c317e4
add vector call declaration to trigonemtry
EricAtORS Apr 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,5 @@ vc-benchmarks
.makeApidox.stamp
.makeApidox.stamp.new
build-*
.vs
out
12 changes: 6 additions & 6 deletions Vc/common/trigonometric.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,12 +63,12 @@ namespace Common
{
template<typename Impl> struct Trigonometric
{
template<typename T> static T sin(const T &_x);
template<typename T> static T cos(const T &_x);
template<typename T> static void sincos(const T &_x, T *_sin, T *_cos);
template<typename T> static T asin (const T &_x);
template<typename T> static T atan (const T &_x);
template<typename T> static T atan2(const T &y, const T &x);
template<typename T> static T Vc_VDECL sin(const T &_x);
template<typename T> static T Vc_VDECL cos(const T &_x);
template<typename T> static void Vc_VDECL sincos(const T &_x, T *_sin, T *_cos);
template<typename T> static T Vc_VDECL asin (const T &_x);
template<typename T> static T Vc_VDECL atan (const T &_x);
template<typename T> static T Vc_VDECL atan2(const T &y, const T &x);
};
} // namespace Common

Expand Down
1 change: 1 addition & 0 deletions cmake/VcMacros.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,6 +338,7 @@ int main() { return 0; }
add_definitions(-D_CRT_SECURE_NO_WARNINGS)
endif()
vc_add_compiler_flag(Vc_COMPILE_FLAGS "/Gv") # default to __vectorcall
vc_add_compiler_flag(Vc_COMPILE_FLAGS "/bigobj") # required for building tests with AVX
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested locally and this option is indeed required for debug builds.


if(MSVC_VERSION LESS 1900)
UserWarning("MSVC before 2015 does not support enough of C++11")
Expand Down