Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom offsetof implementation #313

Merged
merged 1 commit into from Mar 22, 2022
Merged

Remove custom offsetof implementation #313

merged 1 commit into from Mar 22, 2022

Conversation

hahnjo
Copy link
Contributor

@hahnjo hahnjo commented Mar 17, 2022

Clang complains that "performing pointer subtraction with a null pointer may have undefined behavior" and the whole code path doesn't seem to be necessary anymore with current compilers.

@bernhardmgruber
Copy link
Collaborator

@hahnjo we had to fix some isses with the CI first (see #317). Could you please rebase your PR? Thank you!

Clang complains that "performing pointer subtraction with a null pointer
may have undefined behavior" and the whole code path doesn't seem to be
necessary anymore with current compilers.
@bernhardmgruber bernhardmgruber merged commit 8e0e200 into VcDevel:1.4 Mar 22, 2022
@hahnjo hahnjo deleted the offsetof branch March 23, 2022 07:35
@bernhardmgruber bernhardmgruber added this to the Vc 1.4.3 milestone Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants