Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support AMD zen3 #317

Merged
merged 2 commits into from Mar 22, 2022
Merged

Support AMD zen3 #317

merged 2 commits into from Mar 22, 2022

Conversation

bernhardmgruber
Copy link
Collaborator

@bernhardmgruber bernhardmgruber commented Mar 21, 2022 •
edited

Github's runners seem to use AMD zen3 CPUs recently and this causes the CI to fail. This PR adds the minimum support to make Vc detect and build for AMD zen3. I also adds new warnings to cmake in case the CPU family was not recognized.

@bernhardmgruber bernhardmgruber changed the title Warn if CPU family is not supported Warn if CPU family is not supported and support AMD zen3 Mar 21, 2022
@bernhardmgruber
Copy link
Collaborator Author

Looks good so far. Now we need to make icc work on the AMD Zen3 runners: Please verify that both the operating system and the processor support Intel(R) X87, CMOV, MMX, FXSAVE, SSE, SSE2, SSE3, SSSE3, SSE4_1, SSE4_2, MOVBE, POPCNT, AVX, F16C, FMA, BMI, LZCNT and AVX2 instructions.

@bernhardmgruber
Copy link
Collaborator Author

bernhardmgruber commented Mar 22, 2022 •
edited

Testing locally on my Ryzen (zen3) I do not have:
fxsave
lzcnt
bmi? (zen3 has bmi1 bmi2)

@bernhardmgruber bernhardmgruber force-pushed the cpufamility branch 2 times, most recently from f9f5330 to 401ce76 Compare March 22, 2022 10:53
@bernhardmgruber
Copy link
Collaborator Author

The problem was that if the target architecture was detected as zen or zen3, then we also added skylake to the list of march flags to test, which causes icc to pass -xCORE-AVX2. We fixed that now and icc should pass -xAVX2.

@bernhardmgruber bernhardmgruber changed the title Warn if CPU family is not supported and support AMD zen3 Support AMD zen3 Mar 22, 2022
@amadio amadio merged commit c0e6b8d into VcDevel:1.4 Mar 22, 2022
@bernhardmgruber bernhardmgruber deleted the cpufamility branch March 22, 2022 14:01
@bernhardmgruber bernhardmgruber mentioned this pull request Mar 22, 2022
Merged
@bernhardmgruber bernhardmgruber added this to the Vc 1.4.3 milestone Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amadio amadio Awaiting requested review from amadio

Assignees
No one assigned
Labels
target: x86 type: enhancement
Projects
None yet
Milestone
Vc 1.4.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bernhardmgruber @amadio