Add: Remove double actions (orders to civilians)

[1kuemmel1]

• Add: Remove double actions (orders to civilians).

When merged this pull request will:

• Remove the "Get Down!" and "Go Away!" actions from ACE³-interaction menu (see screenshots below)

Final test:

• local
• server

Screenshots
OLD:

NEW:

[Vdauphin]

Hello, sadly I am not sure if this approach will work on all class name (see acemod/ACE3#2576 (comment)). Looks like some mods are not compatible with CBA XEH (Giallustio@33323af#diff-92e95921cfc9c8acde69602348016377).

I don't have a lot of knowledge on this. If this work on dedicate with all mod supported by the H&M, I will accept it.

If it is not working, use the Giallustio approach (https://github.com/Vdauphin/HeartsAndMinds/blob/master_daily/=BTC=co@30_Hearts_and_Minds.Altis/core/fnc/int/add_actions.sqf)

[1kuemmel1]

Oh, I didn't know about this.

If this work on dedicate with all mod supported by the H&M, I will accept it.

Give me some time 😆. I will test this.

[1kuemmel1]

Hiho here is a first review/feedback.
(All mods tested local and on server, all mods are up to date - 05. Dec.17)

• EricJ: Afghan Civilians (Side: CIV) = Not Working
• Bohemia Interactive: Civils (Side: CIV) = Vanilla 😄 - Works fine
• btc_militia_mod Giallustio: Afghan Civilians (Side: CIV) = Not Working
• CAF CAF MOD TEAM: African (Side: CIV) = Works fine
• CAF CAF MOD TEAM: Middle Eastern (Side: CIV) = Works fine
• CUP_Units Community Upgrade Project: Civilians (Russian) (Side: CIV) = Not Working
• CUP_Vehicles Bohemia Interactive: Civilians (Chernarus) (Side: CIV) = Not Working
• CUP_Vehicles Bohemia Interactive: Civilians (Sahrani) (Side: CIV) = Not Working
• CUP_Vehicles Community Upgrade Project: Civilians (Takistan) (Side: CIV) = Not Working
• LIB Reyhard & Joarius: 40s Civilians (Side: CIV) = Which mod is this?
• LOP_LeightsOPFOR Project OPFOR: African Civilians (Side: CIV) = Works fine
• LOP_LeightsOPFOR Project OPFOR: Eastern European Civilians (Side: CIV) = Works fine
• LOP_LeightsOPFOR Project OPFOR: Middle Eastern Civilians (Side: CIV) = Works fine
• OPTRE Bohemia Interactive: Civilians (UEG) (Side: CIV) = Works fine
• RDS_CIV_PACK reyhard: Russians (Side: CIV) = Works fine
• UNSUNG Bohemia Interactive: Vietnamese (UNSUNG) (Side: CIV)
  = Works fine

Additional notes for Not Working:

• default ACE³ actions are not removed
• civilians do not respond to orders: Get Down!, Go Away!, Stop! (from H&M and ACE³ interactions)

Update: tested with #440

[Vdauphin]

Good job!
When you say No interactions available at all you mean :
No "Get Down!" and "Go Away!" actions from ACE³-interaction and no "Civil Orders" actions from H&M-interaction ?

[Vdauphin]

This will fix the No interactions available at all problem :)

[1kuemmel1]

Update list.

My conclusion so far: do not implement, because unfortunately not all mods are supported.

[Vdauphin]

Basically it not working because Civilian is not use by some mod in parents class ... I think this would works if you use CAManBase or Man and then use https://github.com/Vdauphin/HeartsAndMinds/blob/master_daily/%3DBTC%3Dco%4030_Hearts_and_Minds.Altis/core/fnc/eh/unit_init.sqf and do a if side == civilian removeinteraction

Or use the add_actions file as said previously

See you!

[1kuemmel1]

Basically it not working because Civilian is not use by some mod in parents class ... I think this would works if you use CAManBase or Man...
This is a good approach!
I will take a look at these the next days.

[Vdauphin]

Check before if mods use CAManBase parent in config to avoid waste of your time

[1kuemmel1]

Please remember; you need #440 for this.

[1kuemmel1]

update: now it´s include the fix from #440

[Vdauphin]

Here your goal is to remove the action. So why not just add in /core/fnc/int/add_actions.sqf#L78 :

{
	//remove "get down" order
	[_x, 0,["ACE_MainActions","ACE_GetDown"]] call ace_interact_menu_fnc_removeActionFromClass;

	//remove "go away" order
	[_x, 0,["ACE_MainActions","ACE_SendAway"]] call ace_interact_menu_fnc_removeActionFromClass;
} forEach btc_civ_type_units;

Just 4 lines of code, nothing complicated. I am agree the CBA Extended_InitPost_EventHandlers is really powerfull but not necessary to do what you want to do. Stay simple.

If you want to take advantage of CBA Extended_InitPost_EventHandlers do it in a seperate pull request and transfer all actions (add_actions.sqf#L53-L77) and call of btc_fnc_mil_unit_create, btc_fnc_civ_unit_create in it. Like Giallustio did in the past : Giallustio@33323af#diff-92e95921cfc9c8acde69602348016377

[Vdauphin]

I will do final phase soon :)