Can't add actions to main class #2576

Giallustio · 2015-09-23T12:12:51Z

It seems that i can not attach an action to a main class, like LandVehicle, the same action works for a defined class:

_action = ["Logistic","Logistic","",{hint "CIAO"},{true}] call ace_interact_menu_fnc_createAction; ["LandVehicle", 0, ["ACE_MainActions"], _action] call ace_interact_menu_fnc_addActionToClass;

//////////////////////////////////////////////////////////////////////////

_action = ["Logistic","Logistic","",{hint "CIAO"},{true}] call ace_interact_menu_fnc_createAction; ["B_Truck_01_transport_F", 0, ["ACE_MainActions"], _action] call ace_interact_menu_fnc_addActionToClass;

commy2 · 2015-09-23T12:42:16Z

Try it with Car, Tank, Helicopter, Plane and Ship_F.

Giallustio · 2015-09-23T12:52:13Z

Same result

commy2 · 2015-09-23T12:54:55Z

Oh yes. Checked the code and createAction is not meant to work with base classes.

Giallustio · 2015-09-23T13:01:10Z

Could it be changed?

commy2 · 2015-09-23T13:04:38Z

Not that easily. But you really don't need it on base classes. Here is how we do it:

ACE3/addons/cargo/CfgEventHandlers.hpp

Lines 20 to 25 in 45e4425

    
           class Extended_InitPost_EventHandlers { 
        
               class StaticWeapon { 
        
                   class ADDON { 
        
                       init = QUOTE(_this call DFUNC(initObject)); 
        
                   }; 
        
               };

ACE3/addons/cargo/functions/fnc_initVehicle.sqf

Line 22 in 45e4425

_type = typeOf _vehicle;

You just have to make sure that the action is only added to each vehicle type once if you place multiple copies of one type:

ACE3/addons/cargo/functions/fnc_initVehicle.sqf

Lines 37 to 41 in 45e4425

    
           // do nothing if the class is already initialized 
        
           if (_type in _initializedClasses) exitWith {}; 
        
           // set class as initialized 
        
           _initializedClasses pushBack _type; 
        
           SETMVAR(GVAR(initializedClasses),_initializedClasses);

If this is for a mission, then you can simply put the Extended_InitPost_Eventhandler into the description.ext.

Giallustio · 2015-09-23T15:31:09Z

I'm gonna check it later, ty commy!

Side question, in this way i can add an action to every object and to every class. What's the best option for performance? I don't know how the action system work, so i can't judge

commy2 · 2015-09-23T18:49:36Z

It should make no noticable difference.

PabstMirror · 2015-09-23T19:22:27Z

It's minor, but I think it's slightly faster to add to class.

Plus you have less total variables on each object

Giallustio · 2015-09-23T19:28:06Z

Thank you guys, it works perfectly now!

commy2 · 2015-09-23T19:38:29Z

yay

Giallustio · 2015-11-09T13:20:15Z

Sorry Commy to bring it up again, but i've a problem with your solution.

It works perfectly in SP editor, but not in MP.

class Extended_InitPost_EventHandlers {
    class Man {
        class ADDON {
            init = "_this call btc_fnc_eh_unit_init";
        };
    };
};

btc_fnc_eh_unit_init:

private ["_unit"];

_unit = _this select 0;

switch true do {
    case (side _unit == btc_enemy_side) : {
        private ["_type", "_action"];
        if (isServer) then {_unit call btc_fnc_mil_unit_create;};
        _type = typeOf _unit;
        if (isNil "btc_actions_units") then {btc_actions_units = [];};
        if !(_type in btc_actions_units) then {
            btc_actions_units pushBack _type;
            _action = ["Search_intel", "Search for intel", "", {(_this select 0) spawn btc_fnc_info_search_for_intel;}, {!Alive (_this select 0)}] call ace_interact_menu_fnc_createAction;
            [_type, 0, ["ACE_MainActions"], _action] call ace_interact_menu_fnc_addActionToClass;
        };
    };
};

PabstMirror · 2015-11-09T17:52:28Z

When is btc_enemy_side defined?

init.sqf runs at different times in SP and MP

Giallustio · 2015-11-09T17:57:40Z

call compile preprocessFile "core\def\mission.sqf";

called by init.sqf

All the units are spawned during the game

PabstMirror · 2015-11-09T18:09:09Z

class Extended_PreInit_EventHandlers {
    class yourmission {
        init = 'call compile preprocessFile "core\def\mission.sqf";';
    };
};

jokoho48 · 2015-11-09T18:14:23Z

i think you need to use this

class Extended_Init_Eventhandlers {
    class CAManBase {
        class yourmission_init {
            init = "call compile preprocessFile 'core\def\mission.sqf'";
        };
    };
};

Giallustio · 2015-11-09T18:41:12Z

nope, i've tried to define it inside the same fnc and it's not working

private ["_unit"];

_unit = _this select 0;
btc_enemy_side = east;
switch true do {
    case (side _unit == btc_enemy_side) : {

Giallustio · 2015-11-10T08:26:49Z

*not working

Giallustio · 2015-11-11T20:00:57Z

Few more tests:

btc_enemy_side is initialized correctly.

type has been added to btc_actions_units.

if i spawn a sleep the action will be added correctly:

                _unit spawn {
                    sleep 1;
                    _action = ["Search_intel", "Search for intel", "", {(_this select 0) spawn btc_fnc_info_search_for_intel;}, {!Alive (_this select 0)}] call ace_interact_menu_fnc_createAction;
                    [(typeOf _this), 0, ["ACE_MainActions"], _action] call ace_interact_menu_fnc_addActionToClass;

But sometime the action is not added even if the type has been added to the main array.

I tried to check the actions of the class and this is the result:

20:06:44 "[["ACE_MainActions","Interactions","\a3\ui_f\data\IGUI\Cfg\Actions\eject_ca.paa",{},{true},{},[],{_target selectionPosition 'pelvis'},4,[false,false,false,false,false],{}],[[["ACE_TeamManagement","Team Management","\z\ace\addons\interaction\UI\team\team_management_ca.paa",{},{[_player, _target] call ace_interaction_fnc_canJoinTeam && {ace_interaction_EnableTeamManagement} && {[ACE_player,  _target,  []] call ace_common_fnc_canInteractWith} },{},[],{[0,0,0]},0,[false,false,false,false,false],{}],[[["ACE_AssignTeamRed","Assign Red","\z\ace\addons\interaction\UI\team\team_red_ca.paa",{[_target, 'RED'] call ace_interaction_fnc_joinTeam},{[_player, _target] call ace_interaction_fnc_canJoinTeam && {[ACE_player,  _target,  []] call ace_common_fnc_canInteractWith} },{},[],{[0,0,0]},0,[true,false,false,false,false],{}],[]],[["ACE_AssignTeamGreen","Assign Green","\z\ace\addons\interaction\UI\team\team_green_ca.paa",{[_target, 'GREEN'] call ace_interaction_fnc_joinTeam},{[_player, _target] call ace_interaction_fnc_can
20:06:45 "[["ACE_Torso","Torso","\z\ace\addons\medical\UI\icons\medical_cross.paa",{[_target,  true,  1] call ace_medical_fnc_displayPatientInformation},{ace_medical_menuTypeStyle == 0 && {[ACE_player,  _target,  []] call ace_common_fnc_canInteractWith} },{},[],{_target selectionPosition 'spine3'},1.75,[false,false,false,true,false],{[_target, _player, 1, _this select 3] call ace_medical_fnc_modifyMedicalAction}],[[["Bandage","Bandage","\z\ace\addons\medical\UI\icons\bandage.paa",{[_player,  _target,  'body',  'Bandage'] call ace_medical_fnc_treatment},{[_player,  _target,  'body',  'Bandage'] call ace_medical_fnc_canTreatCached && {[ACE_player,  _target,  []] call ace_common_fnc_canInteractWith} },{},[],{[0,0,0]},2,[true,true,false,false,false],{}],[]],[["PlaceInBodyBag","Place body in bodybag","",{[_player,  _target,  'body',  'BodyBag'] call ace_medical_fnc_treatment},{[_player,  _target,  'body',  'BodyBag'] call ace_medical_fnc_canTreatCached && {[ACE_player,  _target,  []] call ace_common_fnc_canInteractWith} }
20:06:45 "[["ACE_Head","Head","\z\ace\addons\medical\UI\icons\medical_cross.paa",{[_target,  true,  0] call ace_medical_fnc_displayPatientInformation},{ace_medical_menuTypeStyle == 0 && {[ACE_player,  _target,  []] call ace_common_fnc_canInteractWith} },{},[],{_target selectionPosition 'pilot'},1.75,[false,false,false,true,false],{[_target, _player, 0, _this select 3] call ace_medical_fnc_modifyMedicalAction}],[[["Bandage","Bandage","\z\ace\addons\medical\UI\icons\bandage.paa",{[_player,  _target,  'head',  'Bandage'] call ace_medical_fnc_treatment},{[_player,  _target,  'head',  'Bandage'] call ace_medical_fnc_canTreatCached && {[ACE_player,  _target,  []] call ace_common_fnc_canInteractWith} },{},[],{[0,0,0]},2,[true,false,false,false,false],{}],[]],[["FieldDressing","Field Dressing","\z\ace\addons\medical\UI\icons\bandage.paa",{[_player,  _target,  'head',  'FieldDressing'] call ace_medical_fnc_treatment},{[_player,  _target,  'head',  'FieldDressing'] call ace_medical_fnc_canTreatCached && {[ACE_player,  _target,
20:06:45 "[["ACE_ArmLeft","Left Arm","\z\ace\addons\medical\UI\icons\medical_cross.paa",{[_target,  true,  2] call ace_medical_fnc_displayPatientInformation},{ace_medical_menuTypeStyle == 0 && {[ACE_player,  _target,  []] call ace_common_fnc_canInteractWith} },{},[],{_target selectionPosition 'LeftForeArm'},1.75,[false,false,false,true,false],{[_target, _player, 2, _this select 3] call ace_medical_fnc_modifyMedicalAction}],[[["Bandage","Bandage","\z\ace\addons\medical\UI\icons\bandage.paa",{[_player,  _target,  'hand_l',  'Bandage'] call ace_medical_fnc_treatment},{[_player,  _target,  'hand_l',  'Bandage'] call ace_medical_fnc_canTreatCached && {[ACE_player,  _target,  []] call ace_common_fnc_canInteractWith} },{},[],{[0,0,0]},2,[true,false,false,false,false],{}],[]],[["FieldDressing","Field Dressing","\z\ace\addons\medical\UI\icons\bandage.paa",{[_player,  _target,  'hand_l',  'FieldDressing'] call ace_medical_fnc_treatment},{[_player,  _target,  'hand_l',  'FieldDressing'] call ace_medical_fnc_canTreatCached && {[
20:06:45 "[["ACE_ArmRight","Right Arm","\z\ace\addons\medical\UI\icons\medical_cross.paa",{[_target,  true,  3] call ace_medical_fnc_displayPatientInformation},{ace_medical_menuTypeStyle == 0 && {[ACE_player,  _target,  []] call ace_common_fnc_canInteractWith} },{},[],{_target selectionPosition 'RightForeArm'},1.75,[false,false,false,true,false],{[_target, _player, 3, _this select 3] call ace_medical_fnc_modifyMedicalAction}],[[["Bandage","Bandage","\z\ace\addons\medical\UI\icons\bandage.paa",{[_player,  _target,  'hand_r',  'Bandage'] call ace_medical_fnc_treatment},{[_player,  _target,  'hand_r',  'Bandage'] call ace_medical_fnc_canTreatCached && {[ACE_player,  _target,  []] call ace_common_fnc_canInteractWith} },{},[],{[0,0,0]},2,[true,false,false,false,false],{}],[]],[["FieldDressing","Field Dressing","\z\ace\addons\medical\UI\icons\bandage.paa",{[_player,  _target,  'hand_r',  'FieldDressing'] call ace_medical_fnc_treatment},{[_player,  _target,  'hand_r',  'FieldDressing'] call ace_medical_fnc_canTreatCached &&
20:06:45 "[["ACE_LegLeft","Left Leg","\z\ace\addons\medical\UI\icons\medical_cross.paa",{[_target,  true,  4] call ace_medical_fnc_displayPatientInformation},{ace_medical_menuTypeStyle == 0 && {[ACE_player,  _target,  []] call ace_common_fnc_canInteractWith} },{},[],{_target selectionPosition 'LKnee'},1.75,[false,false,false,true,false],{[_target, _player, 4, _this select 3] call ace_medical_fnc_modifyMedicalAction}],[[["Bandage","Bandage","\z\ace\addons\medical\UI\icons\bandage.paa",{[_player,  _target,  'leg_l',  'Bandage'] call ace_medical_fnc_treatment},{[_player,  _target,  'leg_l',  'Bandage'] call ace_medical_fnc_canTreatCached && {[ACE_player,  _target,  []] call ace_common_fnc_canInteractWith} },{},[],{[0,0,0]},2,[true,false,false,false,false],{}],[]],[["FieldDressing","Field Dressing","\z\ace\addons\medical\UI\icons\bandage.paa",{[_player,  _target,  'leg_l',  'FieldDressing'] call ace_medical_fnc_treatment},{[_player,  _target,  'leg_l',  'FieldDressing'] call ace_medical_fnc_canTreatCached && {[ACE_player
20:06:45 "[["ACE_LegRight","Right Leg","\z\ace\addons\medical\UI\icons\medical_cross.paa",{[_target,  true,  5] call ace_medical_fnc_displayPatientInformation},{ace_medical_menuTypeStyle == 0 && {[ACE_player,  _target,  []] call ace_common_fnc_canInteractWith} },{},[],{_target selectionPosition 'RKnee'},1.75,[false,false,false,true,false],{[_target, _player, 5, _this select 3] call ace_medical_fnc_modifyMedicalAction}],[[["Bandage","Bandage","\z\ace\addons\medical\UI\icons\bandage.paa",{[_player,  _target,  'leg_r',  'Bandage'] call ace_medical_fnc_treatment},{[_player,  _target,  'leg_r',  'Bandage'] call ace_medical_fnc_canTreatCached && {[ACE_player,  _target,  []] call ace_common_fnc_canInteractWith} },{},[],{[0,0,0]},2,[true,false,false,false,false],{}],[]],[["FieldDressing","Field Dressing","\z\ace\addons\medical\UI\icons\bandage.paa",{[_player,  _target,  'leg_r',  'FieldDressing'] call ace_medical_fnc_treatment},{[_player,  _target,  'leg_r',  'FieldDressing'] call ace_medical_fnc_canTreatCached && {[ACE_play
20:06:45 "[["ACE_Weapon","Weapon","",{},{true && {[ACE_player,  _target,  []] call ace_common_fnc_canInteractWith} },{},[],{call ace_interaction_fnc_getWeaponPos},1.5,[false,false,false,false,false],{}],[[["ace_reload_LinkBelt","Link belt","",{[_player,  _target] call ace_reload_fnc_startLinkingBelt},{[_player,  _target] call ace_reload_fnc_canLinkBelt && {[ACE_player,  _target,  []] call ace_common_fnc_canInteractWith} },{},[],{[0,0,0]},2,[false,false,false,false,false],{}],[]],[["ace_reload_CheckAmmo","Check Ammo","",{[_player,  _target] call ace_reload_fnc_checkAmmo},{[_player,  _target] call ace_reload_fnc_canCheckAmmo && {[ACE_player,  _target,  []] call ace_common_fnc_canInteractWith} },{},[],{[0,0,0]},2,[false,false,false,false,false],{}],[]],[["ace_rangecard_copyRangeCard","Copy Range Card","\z\ace\addons\rangecard\UI\RangeCard_Icon.paa",{_target call ace_rangecard_fnc_updateClassNames},{_target call ace_rangecard_fnc_canCopy && {[ACE_player,  _target,  []] call ace_common_fnc_canInteractWith} },{},[],{[0,0,0
20:06:45 "[["ACE_TapShoulderRight","Tap Shoulder","",{[_player,  _target,  0] call ace_interaction_fnc_tapShoulder},{[_player,  _target] call ace_interaction_fnc_canTapShoulder && {[ACE_player,  _target,  []] call ace_common_fnc_canInteractWith} },{},[],{_target selectionPosition 'rightshoulder'},2,[false,false,false,false,false],{}],[]]"
20:06:45 "[["ACE_TapShoulderLeft","Tap Shoulder","",{[_player,  _target,  1] call ace_interaction_fnc_tapShoulder},{[_player,  _target] call ace_interaction_fnc_canTapShoulder && {[ACE_player,  _target,  []] call ace_common_fnc_canInteractWith} },{},[],{_target selectionPosition 'leftshoulder'},2,[false,false,false,false,false],{}],[]]"
20:06:45 "[["ace_reloadlaunchers_ReloadLauncher","Load launcher","",{},{true && {[ACE_player,  _target,  []] call ace_common_fnc_canInteractWith} },{_this call ace_reloadlaunchers_fnc_addMissileReloadActions},[],{_target selectionPosition 'launcher'},4,[false,false,false,false,false],{}],[]]"
20:06:45 "[["ACE_ApplyHandcuffs","Take Prisoner","\z\ace\addons\captives\UI\handcuff_ca.paa",{[_player,  _target] call ace_captives_fnc_doApplyHandcuffs},{[_player,  _target] call ace_captives_fnc_canApplyHandcuffs && {[ACE_player,  _target,  []] call ace_common_fnc_canInteractWith} },{},[],{_target selectionPosition 'righthand'},2,[false,false,false,false,false],{}],[]]"
20:06:45 "[["ace_dragging_drop","Release","",{[_player, _target] call ace_dragging_fnc_dropObject},{[_player, _target] call ace_dragging_fnc_canDrop},{},[],{[0, 0, 0]},2,[false,false,false,false,false],{}],[]]"

The class was O_G_Soldier_F

PabstMirror · 2015-11-11T20:29:58Z

Description.ext:

//This defines the function:
class Extended_PreInit_EventHandlers {
    class yourPreInitToDefineFunc {
        init = "btc_fnc_eh_unit_init = compile preProcessFileLineNumbers 'btc_fnc_eh_unit_init.sqf';";
    };
};

//This runs func at initPost:
class Extended_InitPost_EventHandlers {
    class CAManBase {
        class addMyAction {
            init = "_this call btc_fnc_eh_unit_init";
        };
    };
};

btc_fnc_eh_unit_init.sqf:

private ["_unit"];

_unit = _this select 0;

diag_log text format ["running unit init on [%1]-[%2]", _unit, typeOf _unit];

_type = typeOf _unit;
if (isNil "btc_actions_units") then {btc_actions_units = [];};

if !(_type in btc_actions_units) then {
    btc_actions_units pushBack _type;

    _action = ["Search_intel", "Search for intel on dead guy", "", {systemChat "searching..."}, {!alive _target}] call ace_interact_menu_fnc_createAction;
    [_type, 0, ["ACE_MainActions"], _action] call ace_interact_menu_fnc_addActionToClass;
};

This works in SP and MP

jokoho48 · 2015-11-11T20:46:25Z

@PabstMirror
class Extended_InitPost_EventHandlers { class CAManBase { class addMyAction { init = "_this call btc_fnc_eh_unit_init"; }; }; };

dont work you must use Extended_Init_EventHandlers

Giallustio · 2015-11-11T20:55:59Z

still not working for me.
If you want to take a look:

Giallustio/HeartsAndMinds@ab5e675

jokoho48 · 2015-11-11T20:59:18Z

https://github.com/jokoho48/AWPublicMission/blob/DCGAW/data/SEN_XEH.hpp#L9-L15
this are the right config entry for this

Giallustio · 2015-11-12T09:22:11Z

It fails on some units class and i can't reproduce the error. I'm gonna change approach

jokoho48 · 2015-11-12T09:36:10Z

the unit classes where it fail are not compatible with CBA XEH than you must contact the author of the mod and say him to fix this

Giallustio · 2015-11-12T09:41:30Z

Arma vanilla units. Guerilla opfor faction.
The code runs because the class is in the array, but the action won't show up on some units. I checked all the variables of missionnamespace and the action is not there for those units.

Units spawned with zeus are fine tho (CSAT)

jokoho48 · 2015-11-12T09:46:41Z

did you load RHS?

Giallustio · 2015-11-12T09:58:01Z

yep! CBA, ACE, RHS

jokoho48 · 2015-11-12T10:03:50Z

then try it without RHS because RHS break CBA XEH

commy2 added the kind/question label Sep 23, 2015

commy2 self-assigned this Sep 23, 2015

commy2 closed this as completed Sep 23, 2015

jokoho48 reopened this Nov 11, 2015

jokoho48 closed this as completed Nov 11, 2015

Vdauphin mentioned this issue Nov 27, 2017

Add: Remove double actions (orders to civilians) Vdauphin/HeartsAndMinds#439

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Can't add actions to main class #2576

Can't add actions to main class #2576

Giallustio commented Sep 23, 2015

commy2 commented Sep 23, 2015

Giallustio commented Sep 23, 2015

commy2 commented Sep 23, 2015

Giallustio commented Sep 23, 2015

commy2 commented Sep 23, 2015

Giallustio commented Sep 23, 2015

commy2 commented Sep 23, 2015

PabstMirror commented Sep 23, 2015

Giallustio commented Sep 23, 2015

commy2 commented Sep 23, 2015

Giallustio commented Nov 9, 2015

PabstMirror commented Nov 9, 2015

Giallustio commented Nov 9, 2015

PabstMirror commented Nov 9, 2015

jokoho48 commented Nov 9, 2015

Giallustio commented Nov 9, 2015

Giallustio commented Nov 10, 2015

Giallustio commented Nov 11, 2015

PabstMirror commented Nov 11, 2015

jokoho48 commented Nov 11, 2015

Giallustio commented Nov 11, 2015

jokoho48 commented Nov 11, 2015

Giallustio commented Nov 12, 2015

jokoho48 commented Nov 12, 2015

Giallustio commented Nov 12, 2015

jokoho48 commented Nov 12, 2015

Giallustio commented Nov 12, 2015

jokoho48 commented Nov 12, 2015

Can't add actions to main class #2576

Can't add actions to main class #2576

Comments

Giallustio commented Sep 23, 2015

commy2 commented Sep 23, 2015

Giallustio commented Sep 23, 2015

commy2 commented Sep 23, 2015

Giallustio commented Sep 23, 2015

commy2 commented Sep 23, 2015

Giallustio commented Sep 23, 2015

commy2 commented Sep 23, 2015

PabstMirror commented Sep 23, 2015

Giallustio commented Sep 23, 2015

commy2 commented Sep 23, 2015

Giallustio commented Nov 9, 2015

PabstMirror commented Nov 9, 2015

Giallustio commented Nov 9, 2015

PabstMirror commented Nov 9, 2015

jokoho48 commented Nov 9, 2015

Giallustio commented Nov 9, 2015

Giallustio commented Nov 10, 2015

Giallustio commented Nov 11, 2015

PabstMirror commented Nov 11, 2015

jokoho48 commented Nov 11, 2015

Giallustio commented Nov 11, 2015

jokoho48 commented Nov 11, 2015

Giallustio commented Nov 12, 2015

jokoho48 commented Nov 12, 2015

Giallustio commented Nov 12, 2015

jokoho48 commented Nov 12, 2015

Giallustio commented Nov 12, 2015

jokoho48 commented Nov 12, 2015