Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make additional library dependencies optional #515

Merged
merged 12 commits into from
Nov 28, 2023

Conversation

amrit110
Copy link
Member

PR Type ([Feature | Fix | Documentation | Test])

Improvement to use of dependencies

Short Description

  • Make modelling libraries like torch, xgboost optional
  • Make alibi, alibi-detect, torchxrayvision, torchvision optional

Tests Added

...

@amrit110 amrit110 self-assigned this Nov 27, 2023
@amrit110 amrit110 added the refactor Refactor existing code, with same or similar functionality label Nov 27, 2023
@amrit110 amrit110 requested review from a-kore and removed request for a-kore November 28, 2023 13:37
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Merging #515 (de5ae14) into main (81fc151) will increase coverage by 0.47%.
The diff coverage is 70.11%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #515      +/-   ##
==========================================
+ Coverage   64.36%   64.83%   +0.47%     
==========================================
  Files          94       94              
  Lines        9282     9248      -34     
==========================================
+ Hits         5974     5996      +22     
+ Misses       3308     3252      -56     
Files Coverage Δ
cyclops/tasks/base.py 84.50% <100.00%> (ø)
cyclops/data/transforms.py 51.51% <83.33%> (+3.23%) ⬆️
cyclops/data/utils.py 41.17% <80.00%> (+1.17%) ⬆️
cyclops/models/utils.py 80.64% <80.00%> (-11.67%) ⬇️
cyclops/models/wrappers/pt_model.py 81.07% <66.66%> (+1.02%) ⬆️
cyclops/tasks/classification.py 32.65% <80.00%> (+0.70%) ⬆️
cyclops/tasks/utils.py 55.55% <80.00%> (+1.01%) ⬆️
cyclops/models/neural_nets/gru.py 43.47% <71.42%> (+1.37%) ⬆️
cyclops/models/neural_nets/lstm.py 88.00% <71.42%> (-7.24%) ⬇️
cyclops/models/neural_nets/mlp.py 36.11% <75.00%> (+1.73%) ⬆️
... and 11 more

Impacted file tree graph

@amrit110 amrit110 merged commit ae2092a into main Nov 28, 2023
7 checks passed
@amrit110 amrit110 deleted the make_additional_dependencies_optional branch November 28, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactor existing code, with same or similar functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant