Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify process package into data #519

Merged
merged 5 commits into from
Nov 28, 2023
Merged

Conversation

amrit110
Copy link
Member

@amrit110 amrit110 commented Nov 28, 2023

PR Type ([Feature | Fix | Documentation | Test])

Refactor/Unify packages

Short Description

  • Merge process package into data package.
  • Remove slice method in Features since that will be handled by the slicer/HF datasets

Tests Added

...

@amrit110 amrit110 self-assigned this Nov 28, 2023
@amrit110 amrit110 added the refactor Refactor existing code, with same or similar functionality label Nov 28, 2023
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Merging #519 (70c368c) into main (ae2092a) will decrease coverage by 0.06%.
Report is 1 commits behind head on main.
The diff coverage is 93.33%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #519      +/-   ##
==========================================
- Coverage   64.83%   64.77%   -0.06%     
==========================================
  Files          94       93       -1     
  Lines        9248     9227      -21     
==========================================
- Hits         5996     5977      -19     
+ Misses       3252     3250       -2     
Files Coverage Δ
cyclops/data/aggregate.py 75.34% <100.00%> (ø)
cyclops/data/clean.py 95.55% <100.00%> (ø)
cyclops/data/constants.py 100.00% <ø> (ø)
cyclops/data/df/normalize.py 86.98% <100.00%> (ø)
cyclops/data/df/split.py 98.87% <100.00%> (ø)
cyclops/data/diagnoses.py 79.41% <100.00%> (ø)
cyclops/data/impute.py 80.39% <100.00%> (ø)
cyclops/data/string_ops.py 91.80% <100.00%> (ø)
cyclops/data/utils.py 65.21% <100.00%> (+24.04%) ⬆️
cyclops/data/df/feature.py 72.37% <90.00%> (ø)
... and 2 more

Impacted file tree graph

@amrit110 amrit110 merged commit dfc3bfa into main Nov 28, 2023
3 of 4 checks passed
@amrit110 amrit110 deleted the move_process_into_data_package branch November 28, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactor existing code, with same or similar functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant