Support 0x04040404 for supportsInterface function #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
|
Just try catch call Btw, all contracts are automatically whitelisted to skip NFTs. |
|
@Vectorized Hmm would it be problematic if the token is sent before the contract deployment? https://despac1to.medium.com/carefully-use-openzeppelins-address-iscontract-msg-sender-4136cc6ff66d edit ) seems like |
|
🤔 Lemme marinate on this. |
ghost
closed this by deleting the head repository
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Would be great if we could support 0x04040404 as an identifier for DN404 contracts, so that the contract could automatically call setSkipNFT before transfer, etc.
Checklist
Ensure you completed all of the steps below before submitting your pull request:
forge fmt?forge snapshot?forge test?Pull requests with an incomplete checklist will be thrown out.