Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add directReturn to DynamicArrayLib #1110

Merged
merged 2 commits into from
Oct 8, 2024
Merged

✨ Add directReturn to DynamicArrayLib #1110

merged 2 commits into from
Oct 8, 2024

Conversation

Vectorized
Copy link
Owner

Description

Checklist

Ensure you completed all of the steps below before submitting your pull request:

  • Ran forge fmt?
  • Ran forge test?

Pull requests with an incomplete checklist will be thrown out.

Copy link

github-actions bot commented Oct 8, 2024

Gas Snapshot Comparison Report

Generated at commit : d734165, Compared to commit : c8bbc29

Contract Name Test Name Main Gas PR Gas Diff
DynamicArrayLibTest testDynamicArrayPushAfterReserve() 39957 39979 22
testDynamicArraySlice() 11632 11588 -44
testDynamicArrayWrap() 1681 1726 45
testUint256ArrayIndexOf() 17973 17995 22
testUint256ArrayLastIndexOf() 24283 24261 -22
testUint256ArrayMisc() 1056 1011 -45
testUint256ArrayPopulate() 17080 17124 44
testUint256ArrayPopulateOriginal() 22825 22847 22
testUint256Contains() 18300 18345 45
test__codesize() 11355 12119 764

@Vectorized Vectorized merged commit efd064c into main Oct 8, 2024
10 checks passed
@Vectorized Vectorized deleted the direct-return branch October 8, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant