Skip to content

Commit

Permalink
Use a placeholder attribute for search input rather than custom JS
Browse files Browse the repository at this point in the history
  • Loading branch information
autarch committed Sep 15, 2014
1 parent fabf1ea commit dbbe5c8
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 11 deletions.
10 changes: 0 additions & 10 deletions share/js-source/VegGuide/SitewideSearch.js
Expand Up @@ -7,8 +7,6 @@ if ( typeof VegGuide == "undefined" ) {

VegGuide.SitewideSearch = {};

VegGuide.SitewideSearch._defaultValue = "name, city, or address";

VegGuide.SitewideSearch.instrumentPage = function () {
var input = $("sitewide-search-input");

Expand All @@ -17,20 +15,12 @@ VegGuide.SitewideSearch.instrumentPage = function () {
return;
}

if ( input.value == undefined || ! input.value.length ) {
input.value = VegGuide.SitewideSearch._defaultValue;
}

var help_div = $("sitewide-search-help");

DOM.Events.addListener(
input,
"focus",
function (e) {
if ( e.target.value == VegGuide.SitewideSearch._defaultValue ) {
e.target.value = "";
}

VegGuide.SitewideSearch._positionHelpDiv( e.target, help_div );
DOM.Element.show(help_div);
}
Expand Down
2 changes: 1 addition & 1 deletion share/mason/sitewide-search.mas
@@ -1,6 +1,6 @@
<div id="sitewide-search-text-and-form">
<form id="sitewide-search" action="/site/search">
<input id="sitewide-search-input" class="text" type="text" name="search_text" value="<% $search_text | h %>" />
<input id="sitewide-search-input" class="text" type="text" name="search_text" value="<% $search_text | h %>" placeholder="name, city, or address" />
<button class="action-button" type="submit"><% $button | h %></button>
</form>
</div>
Expand Down

0 comments on commit dbbe5c8

Please sign in to comment.