Skip to content

Commit

Permalink
Merge #898: [GUI] Display correct address when transaction has multip…
Browse files Browse the repository at this point in the history
…le addresses…

44e0095 [GUI] Display correct address when transaction has multiple addresses (basecoin) (WetOne)

Pull request description:

  ### Problem
  Basecoin transactions with multiple addresses do not display correctly within the Qt display.

  ### Root Cause
  When creating the transaction the wallet performs an extra push of an address.  This is a non-factor for stealth transactions as stealth transactions use a lookup table for the used address.  The basecoin address gets pushed in.  The extra push performed in the code results in a misalignment which appears when decoding the transaction.

  ### Solution
  Removed the extra push.

  ### Testing
  Tested for basecoin transactions which directly addresses issue 281.  This may also address issue 667 as well.

  ### Related Issues
  #281

Tree-SHA512: a180e84ef0b272ca83a93c4835ff6b75810a485807336cf27e5d3ac6830274ec3cd2e0ba2d195cdd7eb13f27ccce7fc420f4dfb030d85d9bbd5603d9cdfb6fb3
  • Loading branch information
codeofalltrades committed Mar 7, 2021
2 parents 8bd686d + 44e0095 commit 92312a8
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion src/interfaces/wallet.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,6 @@ WalletTx MakeWalletTx(CWallet& wallet, const CWalletTx& wtx)
auto txout = wtx.tx->vpout[i];
auto ismine = wallet.IsMine(txout.get());
result.txout_is_mine.emplace_back(ismine);
result.txout_address.emplace_back();
CScript scriptPubKey;
auto fAddressIsMine = ismine;
if (txout->GetScriptPubKey(scriptPubKey)) {
Expand Down

0 comments on commit 92312a8

Please sign in to comment.