[GUI] Display correct address when transaction has multiple addresses… #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaveSpectre11
added
Coin Type: Basecoin
codeofalltrades
added
Code Review: Passed
and removed
Tag: Waiting For Code Review
CaveSpectre11
added a commit
that referenced
this pull request
May 18, 2021
…rocoin transactions 352d78e transaction list - handle receive from zerocoin transactions (codeofalltrades) Pull request description: ### Problem ### The wallet transaction list was updated to show the correct address #898 Zerocoins sent to a bv1 address were causing the force_return error. The address format is bech32 however the decode method was trying to decode the address as bech32 = false. ### Root Cause ### The address format is bech32 however the decode method was trying to decode the address as bech32 = false. ### Solution ### Decode the address using the correct format. ### Unit Testing Results ### 1. Create a new wallet 2. Get a basecoin address 3. Spend Zerocoins from a different wallet to the basecoin address 4. Verfiy the tx(s) are confirmed in the new wallet 5. Restart the wallet(veil-qt) with -reindex-chainstate 6. Verify the force_return error does not occur Tree-SHA512: bdadeac260673b34e204d00851f7e2c934ec7a46f27494f8f3e0e1122ab3c78ed9638423a0aed883ed883b4cd5f4d9371d83e1a6d2d5241b1576c7661bbcfe7f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Basecoin transactions with multiple addresses do not display correctly within the Qt display.
Root Cause
When creating the transaction the wallet performs an extra push of an address. This is a non-factor for stealth transactions as stealth transactions use a lookup table for the used address. The basecoin address gets pushed in. The extra push performed in the code results in a misalignment which appears when decoding the transaction.
Solution
Removed the extra push.
Testing
Tested for basecoin transactions which directly addresses issue 281. This may also address issue 667 as well.
Related Issues
#281