Remove bit 2 warning.

[presstab]

closes #563

[blondfrogs]

Code looks fine

[presstab]

@blondfrogs forced pushed over what you reviewed. Added iteration over the consensus deployments to manually check if the bit has been defined. It doesn't seem like it serves a good purpose to print a warning of something that your wallet has knowledge of. On the other hand if your wallet does not have knowledge of the bit being signalled, you should be warned.

[blondfrogs]

Makes sense. I like this change

[codablock]

FYI, the real reason for the warning to have appeared is very likely that you have changed nRuleChangeActivationThreshold and nMinerConfirmationWindow without taking the already deployed BIP9 deployments into account. Look at 70de070. This causes things to get messed up now.

The better solution for this would be to maintain these parameters per deployment so that you can vary it when needed. Look at the changes Dash did for DIP1 as an example: dashpay/dash@cd262bf#diff-bc9415451d733499187a3fe59e0fd7e6R34 (the addition of nWindowSize and nThreshold in BIP9Deployment)

[presstab]

@codablock awesome reference thanks for linking it. That would be extremely useful, because (as was the case here) sometimes it is necessary to have faster than usual deployments. Will add this to the list of items to get done before we do another deployment.