Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GUI] Removed faq tabs that weren't been used #698

Merged
merged 1 commit into from
Jan 20, 2020
Merged

[GUI] Removed faq tabs that weren't been used #698

merged 1 commit into from
Jan 20, 2020

Conversation

codeofalltrades
Copy link
Collaborator

Problem

There where non used FAQ forms with similar text to the ones than were being used.

Root Cause

Old forms were never deleted.

Solution

Removed old forms and references

Unit Testing Results

View the FAQ tabs
Verify all display
All formatting issues were corrected with #644

@codeofalltrades codeofalltrades added Tag: Waiting For Code Review Waiting for code review from a core developer Component: GUI Primarily related to the display of the user interface labels Dec 3, 2019
@MatWaller
Copy link
Contributor

Looks good to me Code, Thanks.

@CaveSpectre11 CaveSpectre11 changed the title [Qt] Removed faq tabs that weren't been used [GUI] Removed faq tabs that weren't been used Dec 4, 2019
CaveSpectre11
CaveSpectre11 approved these changes Dec 18, 2019
View reviewed changes
Copy link
Collaborator

@CaveSpectre11 CaveSpectre11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK aeeff2b
(We do need to overhaul our FAQ though)

@codeofalltrades codeofalltrades added Tag: Waiting For QA A pull review is waiting for QA to test the pull request and removed Tag: Waiting For Code Review Waiting for code review from a core developer labels Dec 21, 2019
MatWaller
MatWaller approved these changes Dec 22, 2019
View reviewed changes
Copy link
Contributor

@MatWaller MatWaller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@crypt0-fusi0n crypt0-fusi0n added QA: In Progress This is being tested by the QA team. KEEP CALM and RELAX. and removed Tag: Waiting For QA A pull review is waiting for QA to test the pull request labels Dec 22, 2019
@CaveSpectre11
Copy link
Collaborator

needs rebase

@CaveSpectre11 CaveSpectre11 added the Needs Rebase PR needs to be rebased against current master label Jan 14, 2020
@codeofalltrades
Copy link
Collaborator Author

rebase complete

@codeofalltrades codeofalltrades removed the Needs Rebase PR needs to be rebased against current master label Jan 16, 2020
@ncrypter90
Copy link

Observations:
image

hyperlink does not work:
image

Are these issues fixed in #644? if yes then it can be made test passed.
@codeofalltrades @crypt0-fusi0n

@ncrypter90 ncrypter90 added Tag: Automint QA: Pending QA is waiting a response/confirmation from developers and removed QA: In Progress This is being tested by the QA team. KEEP CALM and RELAX. Tag: Automint labels Jan 19, 2020
@codeofalltrades
Copy link
Collaborator Author

Yes the issues noted where fixed in #644

@codeofalltrades codeofalltrades removed the QA: Pending QA is waiting a response/confirmation from developers label Jan 19, 2020
@codeofalltrades codeofalltrades added the QA: Passed This has passed QA testing and can be merged to master label Jan 19, 2020
codeofalltrades added a commit that referenced this pull request Jan 20, 2020
@codeofalltrades
Merge #698: [GUI] Removed faq tabs that weren't been used
a870362 
613c359 Removed faq tabs that weren't been used (codeofalltrades)

Pull request description:

  ### Problem ###
  There where non used FAQ forms with similar text to the ones than were being used.

  ### Root Cause ###
  Old forms were never deleted.

  ### Solution ###
  Removed old forms and references

  ### Unit Testing Results ###
  View the FAQ tabs
  Verify all display
  All formatting issues were corrected with #644

Tree-SHA512: 9cbde1ebb70733f3fb4d2a6dd18d696683a15fab0d1f8ee92ab75fc3dad3aa04e1b9f7f71b336c05f54cb86a7cb0b927875d0cdc40b227d6a68919a5198d3bc8
@codeofalltrades codeofalltrades merged commit 613c359 into Veil-Project:master Jan 20, 2020
@codeofalltrades codeofalltrades deleted the ux-faq-clean-up branch March 14, 2020 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatWaller MatWaller MatWaller approved these changes

@CaveSpectre11 CaveSpectre11 CaveSpectre11 approved these changes

Assignees

@codeofalltrades codeofalltrades

@ncrypter90 ncrypter90

Labels
Code Review: Passed Component: GUI Primarily related to the display of the user interface QA: Passed This has passed QA testing and can be merged to master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@codeofalltrades @MatWaller @CaveSpectre11 @ncrypter90 @crypt0-fusi0n