[GUI][Zerocoin] transaction list - handle receive from zerocoin transactions

[codeofalltrades]

Problem

The wallet transaction list was updated to show the correct address #898
Zerocoins sent to a bv1 address were causing the force_return error. The address format is bech32 however the decode method was trying to decode the address as bech32 = false.

Root Cause

The address format is bech32 however the decode method was trying to decode the address as bech32 = false.

Solution

Decode the address using the correct format.

Unit Testing Results

1. Create a new wallet
2. Get a basecoin address
3. Spend Zerocoins from a different wallet to the basecoin address
4. Verfiy the tx(s) are confirmed in the new wallet
5. Restart the wallet(veil-qt) with -reindex-chainstate
6. Verify the force_return error does not occur

[Zannick]

NIT: Can this be condensed into a single line instead of the if? say, something like
bool fBech32 = (bool)boost::get<CScriptID>(...); or boost::get<CScriptID>(...) != ... ?

[CaveSpectre11]

That's true:
bool fBech32 = boost::get<CScriptID>(&wtx.txout_address[i]) would do the trick; but functionally it's the same and and it's not against style; so I'll say that's a NIT

Another NIT: space between the end of the if and the {

But given problems with this problem, I'm not concerned with holding it up.

[CaveSpectre11]

utACK 352d78e

[CaveSpectre11]

That's true:
bool fBech32 = boost::get<CScriptID>(&wtx.txout_address[i]) would do the trick; but functionally it's the same and and it's not against style; so I'll say that's a NIT

Another NIT: space between the end of the if and the {

But given problems with this problem, I'm not concerned with holding it up.

[WetOne]

utACK 352d78e