Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Plugin] Plural Kit Integration #2536

Closed
wants to merge 1 commit into from
Closed

Conversation

Scyye
Copy link
Contributor

@Scyye Scyye commented Jun 2, 2024

Fork of PluralChum for Vencord

Current features include:

  1. Edit button
  2. Member IDs in chat
  3. Member colour in chat

Planned features:

  1. PK badge, compatible with moreUserTags
  2. Functional member-specific profile popout
  3. Blocking
  4. Reproxy modal
  5. Option of role colours rather than member colour

There's a few things i dont fully understand how to use (ex. DataStore), if I used that, or anything else incorrectly, or theres any changes needed, please let me know and ill be sure to fix them.

Copy link
Contributor

@MrDiamondDog MrDiamondDog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This plugin seems kinda niche but I'll leave this review

@@ -45,7 +45,8 @@
"gifenc": "github:mattdesl/gifenc#64842fca317b112a8590f8fef2bf3825da8f6fe3",
"monaco-editor": "^0.43.0",
"nanoid": "^4.0.2",
"virtual-merge": "^1.0.1"
"virtual-merge": "^1.0.1",
"pkapi.js": "7.2.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plugins should not add dependencies. This package is just a wrapper around an api, so use that instead


let authors: Record<string, { messageIds: string[]; member: Member|string|undefined; system: System; }> = {};
(async () => {
authors = await DataStore.get<Record<string, { name: string; messageIds: string[]; member: Member|string|undefined; system: System; }>>(DATASTORE_KEY) || {};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put this in your plugin's start function

// I dont fully understand how to use datastores, if i used anything incorrectly please let me know
const DATASTORE_KEY = "pk";

let authors: Record<string, { messageIds: string[]; member: Member|string|undefined; system: System; }> = {};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make this a type instead of typing it out everytime



export default definePlugin({
name: "Plural Kit",
Copy link
Contributor

@MrDiamondDog MrDiamondDog Jun 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your plugin's name should follow our naming convention, so it should be PluralKit

},

async start() {
DataStore.createStore(DATASTORE_KEY, DATASTORE_KEY);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to do this


addButton("pk-edit", msg => {
if (!msg) return null;
console.log(msg);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure you get rid of these

@Vendicated
Copy link
Owner

thanks for your contribution!

unfortunately this is way too niche, sorry

@Vendicated Vendicated closed this Jun 2, 2024
@Scyye
Copy link
Contributor Author

Scyye commented Jun 2, 2024

thanks for your contribution!

unfortunately this is way too niche, sorry
@Vendicated

if i could appeal my ban from the discord, would there be anywhere for me to share it there?

@Scyye
Copy link
Contributor Author

Scyye commented Jun 2, 2024

@Vendicated ?

@lewisakura
Copy link
Sponsor Collaborator

You aren't banned from the Discord server, according to the account you're using as your developer account. Either way, this is not the appropriate place to file such an appeal.

@Scyye
Copy link
Contributor Author

Scyye commented Jun 3, 2024

You aren't banned from the Discord server, according to the account you're using as your developer account. Either way, this is not the appropriate place to file such an appeal.

i wasnt attempting to appeal here, my hope was i would receive a friend request or something of the sort, and i could do it through DMs; where would be the proper place?

@Scyye Scyye deleted the pluralkit branch June 12, 2024 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants