-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Plugin] Plural Kit Integration #2536
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This plugin seems kinda niche but I'll leave this review
@@ -45,7 +45,8 @@ | |||
"gifenc": "github:mattdesl/gifenc#64842fca317b112a8590f8fef2bf3825da8f6fe3", | |||
"monaco-editor": "^0.43.0", | |||
"nanoid": "^4.0.2", | |||
"virtual-merge": "^1.0.1" | |||
"virtual-merge": "^1.0.1", | |||
"pkapi.js": "7.2.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plugins should not add dependencies. This package is just a wrapper around an api, so use that instead
|
||
let authors: Record<string, { messageIds: string[]; member: Member|string|undefined; system: System; }> = {}; | ||
(async () => { | ||
authors = await DataStore.get<Record<string, { name: string; messageIds: string[]; member: Member|string|undefined; system: System; }>>(DATASTORE_KEY) || {}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put this in your plugin's start function
// I dont fully understand how to use datastores, if i used anything incorrectly please let me know | ||
const DATASTORE_KEY = "pk"; | ||
|
||
let authors: Record<string, { messageIds: string[]; member: Member|string|undefined; system: System; }> = {}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make this a type instead of typing it out everytime
|
||
|
||
export default definePlugin({ | ||
name: "Plural Kit", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your plugin's name should follow our naming convention, so it should be PluralKit
}, | ||
|
||
async start() { | ||
DataStore.createStore(DATASTORE_KEY, DATASTORE_KEY); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need to do this
|
||
addButton("pk-edit", msg => { | ||
if (!msg) return null; | ||
console.log(msg); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sure you get rid of these
thanks for your contribution! unfortunately this is way too niche, sorry |
if i could appeal my ban from the discord, would there be anywhere for me to share it there? |
You aren't banned from the Discord server, according to the account you're using as your developer account. Either way, this is not the appropriate place to file such an appeal. |
i wasnt attempting to appeal here, my hope was i would receive a friend request or something of the sort, and i could do it through DMs; where would be the proper place? |
Fork of PluralChum for Vencord
Current features include:
Planned features:
PK
badge, compatible with moreUserTagsThere's a few things i dont fully understand how to use (ex.
DataStore
), if I used that, or anything else incorrectly, or theres any changes needed, please let me know and ill be sure to fix them.