add setConfig method into PopService #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warchant
reviewed
Jan 15, 2020
| @@ -71,6 +72,9 @@ PopServiceImpl::PopServiceImpl() | |||
| LogPrintf("-------------------------------------------------------------------------------------------------\n"); | |||
| StartShutdown(); | |||
| } | |||
| else { | |||
| setConfig(); | |||
There was a problem hiding this comment.
does setConfig remove state stored in alt-service?
There was a problem hiding this comment.
Not at all. The state of the sqllite database with the veriblock blocks and bitcoin blocks will not be removed.
The function which uses this 'using' has been removed
Mr-Leshiy
force-pushed
the
feature/BTC-167
branch
from
eaf3924
to
d3121be
Compare
Warchant
added a commit
that referenced
this pull request
Sep 1, 2021
* Add ci, docker-compose, sonar * Add service locator, pop, rpc services (#1) Signed-off-by: Bogdan Vaneev <warchantua@gmail.com> * Add RPC service implementation (#2) * Add rpc_service_impl Signed-off-by: Bogdan Vaneev <warchantua@gmail.com> * Add opcodes Signed-off-by: Bogdan Vaneev <warchantua@gmail.com> * Link libvbk everywhere Signed-off-by: Bogdan Vaneev <warchantua@gmail.com> * Fix build Signed-off-by: Bogdan Vaneev <warchantua@gmail.com> * Register RPCs Signed-off-by: Bogdan Vaneev <warchantua@gmail.com> * Fix linker error * Make service locator templated * Use default template param to get rid of second overload of get/setService * Set timeout on build Signed-off-by: Bogdan Vaneev <warchantua@gmail.com> * Fix usage on OP_CHECKATV&VTB Signed-off-by: Bogdan Vaneev <warchantua@gmail.com> * Add test template Signed-off-by: Bogdan Vaneev <warchantua@gmail.com> * Add fakeit Signed-off-by: Bogdan Vaneev <warchantua@gmail.com> * Use fixture Signed-off-by: Bogdan Vaneev <warchantua@gmail.com> * Move tests to vbk dir Signed-off-by: Bogdan Vaneev <warchantua@gmail.com> * Fix double free Signed-off-by: Bogdan Vaneev <warchantua@gmail.com> * Fix locator Signed-off-by: Bogdan Vaneev <warchantua@gmail.com> * Disable -fno-devirtualize * Uncomment test Signed-off-by: Bogdan Vaneev <warchantua@gmail.com> * Fix script_test Signed-off-by: Bogdan Vaneev <warchantua@gmail.com> * Fix makefile Signed-off-by: Bogdan Vaneev <warchantua@gmail.com> * Fix flag * Fix -fno-devirtualize flag * Add more interfaces (#3) * Add more interfaces Signed-off-by: Bogdan Vaneev <warchantua@gmail.com> * Remove unneeded comments Signed-off-by: Bogdan Vaneev <warchantua@gmail.com> * Fix build, sonar Signed-off-by: Bogdan Vaneev <warchantua@gmail.com> * Add lcov coverage to sonar (#5) * Add lcov coverage to sonar Signed-off-by: Bogdan Vaneev <warchantua@gmail.com> * Use gcovr Signed-off-by: Bogdan Vaneev <warchantua@gmail.com> * Implement Util Service & add tests (#4) * Implement Util Service & add tests Signed-off-by: Bogdan Vaneev <warchantua@gmail.com> * Add guard impl Signed-off-by: Bogdan Vaneev <warchantua@gmail.com> * Remove slice; include vector Signed-off-by: Bogdan Vaneev <warchantua@gmail.com> * Fix Signed-off-by: Bogdan Vaneev <warchantua@gmail.com> * Add init methods (#7) * Fixe AreInputsStandard, GetTransactionSigOpCostGetP2SHSigOpCount (#6) * Fixe AreInputsStandard, GetTransactionSigOpCostGetP2SHSigOpCount * fixes * fixes * fixes * fixe test, udate UpdateCoins' (#9) * fixes (#12) * fixes * small fixe * fixe * Update src/vbk/util_service/util_service_impl.cpp Co-Authored-By: Bohdan <warchantua@gmail.com> * Update src/script/interpreter.h Co-Authored-By: Bohdan <warchantua@gmail.com> * fixes * bitcoin-cli: convert parameters of the RPC service from JSON as needed (#16) * update mempool, add grpc calls (#14) * update mempool, add grpc calls * remove grpc * fixe * Fix locator (#17) * Fix locator * Fixes * Use clang in CI * Generate genesis blocks; change merkle root calc (#13) * Generate genesis blocks; change merkle root calc * Fixes * Fix main genesis block; disable tests * Fix * Fix make check * tests: add a VeriBlock integration test runner (#10) * tests: add a VeriBlock integration test runner * add a linker flag to resolve circular dependencies * Fix CI * ExtractMatches: fix incorrect condition (#19) * ExtractMatches fixed * Fix BTC-31 * Add SavePopTxToDatabase (#20) * add forkresolution, calculate block without pop tx (#18) * add forkresolution, calculate block without pop tx * Feature/update mempool comparator (#21) * update comparator, add tests * Feature/validate poptx (#22) * Add validate pop tx * Add EvalScript for pOP * Remove unused config const * Fix typo * Fix tests * Feature/pop reward (#23) * add pop rewards * fixe tests * fixes * Feature/fix bitcoind dnsseed (#26) * fix bitcoind * remove seeds and checkpoint data * Feature/add grpc service (#24) * add interface for the statefull block validation * add first verson of grpc class * Add autogeneration * Change submodule git -> https * add grpc calls of the service * add statefull validation * Update proto to v1; fix in Makefile * Fix build * Fix build * fixe * Fix build * Fixes to please CI * Fix build * Fix * Fix * Fix * First version of config... will continue tomorrow * Fix * FIx * add Pop merkle root commitment (#27) * fixe bitcoind * Fix (#28) * Add CD (#30) * Add CD * Try * Try * Try * Fix prerelase on * Add submodules * Update strip code * Remove email * Revert stripping * change the getblocktemplate method (#31) * Feature/disable checks (#32) * Disable requirement on at least one node * Fix tests * Fixes of grpc (#33) * Fixes of grpc * Update docker-compose image * Remove prefix in cd * Fix * Update cd * Fix (#34)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.