Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change import Veriff as named import #23

Merged
merged 2 commits into from May 5, 2022
Merged

Conversation

EhsanParsania
Copy link
Contributor

I tried to import Veriff as default in ES6 style but it didn't work , It seems it is not exported as default , but in document it is imported as default , so I changed as named export and it worked well.

Copy link
Contributor

@fixmk fixmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :) Thank you for noticing this issue.

Copy link
Contributor

@fixmk fixmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually small thing over there - styling. Could you please bring spaces around "Veriff" ?
(Ref: https://eslint.org/docs/rules/object-curly-spacing)

@EhsanParsania
Copy link
Contributor Author

I applied the requested change in style.

Copy link
Contributor

@fixmk fixmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ! Today I will merge it along with package bump (#28) :)

@fixmk fixmk merged commit bc2fc5d into Veriff:master May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants