Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize IL to ensure consistent outcome. #388

Closed
tom-englert opened this issue Nov 12, 2022 · 2 comments
Closed

Normalize IL to ensure consistent outcome. #388

tom-englert opened this issue Nov 12, 2022 · 2 comments

Comments

@tom-englert
Copy link
Contributor

tom-englert commented Nov 12, 2022

Is the feature request related to a problem

Tests occasionally break just because the layout has changed (class/member ordering), while the IL itself is still the same.
see e.g. https://ci.appveyor.com/project/tom-englert/nullguard

see also icsharpcode/ILSpy#2834

Describe the solution

Add option to sort IL output:
icsharpcode/ILSpy#2835

either

Describe alternatives considered

Additional context

Should sorted output be the default (breaking change!) with the possibility to opt out, or better opt in (but you need to do it every time)

@tom-englert
Copy link
Contributor Author

@SimonCropp please comment on the questions, I can then provide a PR.

@SimonCropp
Copy link
Member

happy to accept a PR with this change. also happy to release a new major

tom-englert added a commit to tom-englert/Verify.ICSharpCode.Decompiler that referenced this issue Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants