Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filtering/sorting capabilities to ReflectionDisassembler #2835

Merged

Conversation

tom-englert
Copy link
Contributor

Link to issue(s) this covers

Problem

#2834

Solution

  • Wrap type or member handles in adapter classes so they can be easily exposed to a filter method
  • At least one test covering the code changed

@tom-englert
Copy link
Contributor Author

Release build terminated with timeout. Can s.o. restart it?

@tom-englert
Copy link
Contributor Author

@siegfriedpammer any objections on the latest changes?

@siegfriedpammer
Copy link
Member

No... Looks good now... Will do some clean up and merge soon... Sorry for the delay...

@tom-englert
Copy link
Contributor Author

tom-englert commented Nov 20, 2022

@siegfriedpammer using InstructionOutputExtensions.WriteTo(... to get a methods sort key now includes the method return type, which I explicitly excluded in my implementation.
It should just start with the methods name, followed by the parameters, to get a human readable sort order.

@tom-englert
Copy link
Contributor Author

Any objections to revert that change?

@siegfriedpammer
Copy link
Member

Any objections to revert that change?

No, your changes are fine. Thanks!

@siegfriedpammer siegfriedpammer merged commit 3248657 into icsharpcode:master Nov 20, 2022
@tom-englert tom-englert deleted the SortingReflectionDisassembler branch December 5, 2022 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants