-
-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Issue with report with Linux file paths #1208
fix: Issue with report with Linux file paths #1208
Conversation
jairbubbles
commented
May 21, 2024
- Closes Issue with report with Linux file paths when updating from 23.7.1 to 23.7.2 #1196
…1 to 23.7.2 - Closes VerifyTests#1196
can you include a test? |
@SimonCropp I didn't really how to test the exact flow so I swapped locally compiled .dll and execute on WSL. It seems that reintroducing the replace removed in your commit 7dc99a9 was fixing the issue. |
@SimonCropp Yes I'll add a test. |
@SimonCropp I ended up doing more changes, I fee like it doesn't make much sense to use |
any updates on some tests in this one? |
Hi @SimonCropp, in fact it doesn't need a new test case. This case (build on windows and run on linux) was already covered but the test by itself was not properly detecting the issue because of the mocking . |
@jairbubbles thanks for the clarification. will ship this one now |