Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CodonData class #69 #94

Conversation

shubhwip
Copy link
Contributor

@shubhwip shubhwip commented Oct 1, 2022

Rename class CodonData to CodonDataUtils
Update docs
closes #69

aakash232 and others added 2 commits October 1, 2022 11:42
Added documentation for ProteinFinder

Signed-off-by: Aakash Tyagi <67885496+aakash232@users.noreply.github.com>
Rename class CodonData to CodonDataUtils

Update docs

closes VerisimilitudeX#69
@shubhwip shubhwip force-pushed the enhancement/69-refactor-codondata branch from cf252ac to 37217e1 Compare October 1, 2022 06:58
@shubhwip shubhwip changed the title Separate constants from static functions Refactor CodonData class #69 Oct 1, 2022
yeehawbeans and others added 6 commits October 1, 2022 11:38
Marked methods in utility classes as static and changed their invocations.
Signed-off-by: Hrithik Raj <iamhrithikraj26@gmail.com>
Copy link
Owner

@VerisimilitudeX VerisimilitudeX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@VerisimilitudeX
Copy link
Owner

@shubhwip seems like there are some conflicts. Could you please try to resolve those? Thanks!

VerisimilitudeX and others added 10 commits October 1, 2022 14:44
Signed-off-by: Hrithik Raj <iamhrithikraj26@gmail.com>
Signed-off-by: Hrithik Raj <iamhrithikraj26@gmail.com>
…reExecutor.createProteinList

resolves VerisimilitudeX#80: Refactor CoreExecutor.createProteinList(String,String)
Signed-off-by: Piyush Acharya <acharyapiyush1@outlook.com>
…ng-fixes

Fixed formatting inconsistencies
Rename class CodonData to CodonDataUtils

Update docs

closes VerisimilitudeX#69
Copy link
Owner

@VerisimilitudeX VerisimilitudeX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@VerisimilitudeX VerisimilitudeX merged commit 38fe56c into VerisimilitudeX:main Oct 2, 2022
@shubhwip
Copy link
Contributor Author

shubhwip commented Oct 2, 2022

@Verisimilitude11 Please revert this and merge the latest PR As this merge didn't good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor CodonData.java
5 participants