Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor CodonData.java #69

Closed
VerisimilitudeX opened this issue Sep 29, 2022 · 2 comments · Fixed by #94 or #109
Closed

Refactor CodonData.java #69

VerisimilitudeX opened this issue Sep 29, 2022 · 2 comments · Fixed by #94 or #109
Assignees
@shubhwip
Labels
enhancement New feature or request
Milestone
Strengthen Codebase

Comments

@VerisimilitudeX
Copy link
Owner

I've selected CodonData.java for refactoring, which is a module of 55 lines of code and 21 incoming calls. Addressing this will make our codebase more maintainable and improve Better Code Hub's Separate Concerns in Modules guideline rating! 👍

Here's the gist of this guideline:

  • Definition 📖
    Avoid large modules with high fan-in (nr. of incoming calls).
  • Why❓
    This keeps the codebase loosely coupled which makes it easier to minimize the consequences of changes.
  • How 🔧
    Identify and extract responsibilities of large modules into smaller ones and hide implementation details behind interfaces. Target having modules that have no more than 10 incoming calls.

You can find more info about this guideline in Building Maintainable Software. 📖

ℹ️ To know how many other refactoring candidates need addressing to get a guideline compliant, select some by clicking on the 🔲 next to them. The risk profile below the candidates signals (✅) when it's enough! 🏁

Good luck and happy coding! :shipit: ✨ 💯
@VerisimilitudeX VerisimilitudeX added enhancement New feature or request good first issue Good for newcomers hacktoberfest-accepted labels Sep 30, 2022
@shubhwip
Copy link
Contributor

Can you please assign this to me ?

@VerisimilitudeX
Copy link
Owner Author

👍

shubhwip added a commit to shubhwip/DNAnalyzer that referenced this issue Oct 1, 2022
@shubhwip
Separate constants from static functions
cf252ac 
Rename class CodonData to CodonDataUtils

Upadte docs

closes VerisimilitudeX#69
@shubhwip shubhwip mentioned this issue Oct 1, 2022
Merged
shubhwip added a commit to shubhwip/DNAnalyzer that referenced this issue Oct 1, 2022
@shubhwip
Separate constants from static functions
37217e1 
Rename class CodonData to CodonDataUtils

Update docs

closes VerisimilitudeX#69
@VerisimilitudeX VerisimilitudeX added this to the Strengthen Codebase milestone Oct 2, 2022
@VerisimilitudeX VerisimilitudeX removed the good first issue Good for newcomers label Oct 2, 2022
shubhwip added a commit to shubhwip/DNAnalyzer that referenced this issue Oct 2, 2022
@shubhwip
Separate constants from static functions
681f410 
Rename class CodonData to CodonDataUtils

Update docs

closes VerisimilitudeX#69
shubhwip added a commit to shubhwip/DNAnalyzer that referenced this issue Oct 2, 2022
@shubhwip
Separate constants from static functions
de53afa 
Rename class CodonData to CodonDataUtils

Upadte docs

closes VerisimilitudeX#69
@shubhwip shubhwip mentioned this issue Oct 2, 2022
Merged
VerisimilitudeX added a commit that referenced this issue Oct 2, 2022
@VerisimilitudeX
Merge pull request #94 from shubhwip/enhancement/69-refactor-codondata
38fe56c 
Refactor CodonData class #69
VerisimilitudeX added a commit that referenced this issue Oct 2, 2022
@VerisimilitudeX
Revert "Refactor CodonData class #69"
cca1247
VerisimilitudeX added a commit that referenced this issue Oct 2, 2022
@VerisimilitudeX
Merge pull request #110 from Verisimilitude11/revert-94-enhancement/6…
757178c 
…9-refactor-codondata

Revert "Refactor CodonData class #69"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shubhwip shubhwip

Labels
enhancement New feature or request
Projects
None yet
Milestone
Strengthen Codebase
2 participants
@shubhwip @VerisimilitudeX