This repository has been archived by the owner on Mar 11, 2020. It is now read-only.
Add Service Lookups (WIP) #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can anyone comment on this? Point me in the right direction? |
| case ConsulOp.GetCatalogServices => now(Some("""{"consul":[],"service-name":["tag1","tag2"]}""")) | ||
| } | ||
| } yield () | ||
| interp.run(getJson[Json]("service-name")).run should equal(\/.right(Some(List("tag1","tag2")))) |
There was a problem hiding this comment.
You don't want to be calling getJson here as that's a top level api that calls consul's key value api and decodes the result as json.
see here: https://github.com/Verizon/helm/blob/master/core/src/main/scala/HelmOp.scala#L33
What you probably want to do is follow this pattern with your code. So you'd have
def getService(service: String): ConsulOpF[Option[String]]and then another top level method that calls getService and decodes the json with the given deocder.
def getServiceJson[A:DecodeJson](service: String): ConsulOpF[Err \/ Option[A]]
|
Thanks for the comment. I've gone ahead with another client library, so don't need this PR merged any longer. |
goedelsoup
pushed a commit
to compstak/helm
that referenced
this pull request
Feb 18, 2019
Updated README accordingly to the latest release version.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to add the ability to query the service catalog in Consul. I tried adding the following, but I'm getting a test failure: "could not match expected pattern (ConsulOpTests.scala:73)". For the second test, I don't understand how to decode the JSON consul returns which doesn't have a key, but is just an array like in the mock response.
Any help is greatly appreciated. I'm a little lost in functional land here. ;-)