Skip to content
This repository has been archived by the owner on Mar 11, 2020. It is now read-only.

revert hlist addition to codecs #110

Closed
ahjohannessen opened this issue May 28, 2016 · 2 comments
Closed

revert hlist addition to codecs #110

ahjohannessen opened this issue May 28, 2016 · 2 comments

Comments

@ahjohannessen
Copy link
Contributor

ahjohannessen commented May 28, 2016 •
edited
Loading

I think addition of hlists to Codecs has been more pain than anything else, compile times are staggering once your protocol grows. Honestly I do not see what value it brings about. This is the commit that introduced hlists on Codecs:

a087b00

@timperrett @stew @runarorama WDYT?

If reverting that change is is not desirable, could we then at least find a better way that does not make scalac crap out once the protocol starts to grow?
@ahjohannessen ahjohannessen mentioned this issue May 31, 2016
Open
@timperrett
Copy link
Contributor

@ahjohannessen im ok with reverting this out - i liked the way it was before too

@ahjohannessen
Copy link
Contributor Author

@timperrett I can do the necessary work wrt reverting this out

ahjohannessen added a commit that referenced this issue Jun 1, 2016
@ahjohannessen
core: revert hlist for codecs
a01fa62 
 - revert adding hlists to `Codecs` and adjust
   dependant code / specs accordingly.

 - add convenience syntax for `Protocol` such
   that it is simpler to define (specify)
   signatures for protocols.

 - revert change in `Transport` that causes specs
   to hang.

Closes #110
@ahjohannessen ahjohannessen mentioned this issue Jun 1, 2016
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@timperrett @ahjohannessen