This repository has been archived by the owner on Mar 11, 2020. It is now read-only.
core: revert hlist for codecs #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@timperrett WDYT? |
| @@ -177,9 +177,9 @@ object Enframe extends ChannelOutboundHandlerAdapter { | |||
| obj match { | |||
| case Bits(bv) => | |||
| val byv = bv.toByteVector | |||
There was a problem hiding this comment.
@timperrett This is only here to see if PR builds successfully on Travis, I'll rebase on master when PR that @sbuzzard has open currently is merged.
|
@ahjohannessen so the PR build passed; that was what you were looking for, right? :-) I hope those changes i made to the travis.yml help too! |
- revert adding hlists to `Codecs` and adjust dependant code / specs accordingly. - add convenience syntax for `Protocol` such that it is simpler to define (specify) signatures for protocols. - bump scala to 2.11.8 Closes #110
ahjohannessen
force-pushed
the
wip-revert-hlist-codecs
branch
from
a01fa62
to
8c79dd0
Compare
|
@timperrett I have rebased and think this is ready to be merged - I also bumped scala to 2.11.8 in travis and buil, WDYT? The caching addition is really great! :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Codecsand adjustdependant code / specs accordingly.
Protocolsuchthat it is simpler to define (specify)
signatures for protocols.