Allow custom modules to handle pip-installed custom modules #1554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just took a look. Everything seems solid to me, but is there a test case that we can run to verify the expected behavior? |
What I had in mind is to add a package that we pip-install, add a model that depends on it and then try to deploy. It might require more coordination than this repo allows. We have another repo with end to end tests for that purpose. |
nhatsmrt
approved these changes
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch, we couldn't specify modules installed via pip but that are not available in pypi. The main fix for this is to ignore venv only if the specific desired module is not inside a venv. If it is, then we must include that folder in the custom modules and force the search path to be able to find it.
To facilitate the definition of such custom modules, as they can be pretty deep and different based on how people's envs are setup, we allow the user to pass the name of the module and we resolve to the right path.