Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VR-10494] Notification Channel CRUD #2096

Merged
merged 7 commits into from
Apr 9, 2021
Merged

[VR-10494] Notification Channel CRUD #2096

merged 7 commits into from
Apr 9, 2021

Conversation

convoliution
Copy link
Contributor

@convoliution convoliution commented Apr 7, 2021

from verta import Client
from verta.operations.monitoring.notification_channel import SlackNotificationChannel

client = Client().operations
channel = client.notification_channels.create(
    "slack-webhook",
    SlackNotificationChannel("https://hooks.slack.com/..."),
)

Changes

Config classes

  • Add _NotificationChannel config classes (e.g. SlackNotificationChannel(webhook_url)) to verta.operations.monitoring.notification_channel

Entities

  • Add NotificationChannel create & get via client.notification_channels.create(), etc.

@convoliution convoliution self-assigned this Apr 7, 2021
@convoliution convoliution mentioned this pull request Apr 7, 2021
Copy link
Contributor

@daniel-verta daniel-verta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM minus absence of integration tests.

@convoliution convoliution marked this pull request as ready for review April 9, 2021 02:33
@convoliution convoliution merged commit 99c9261 into master Apr 9, 2021
@convoliution convoliution deleted the ml/VR-10494 branch April 9, 2021 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants