chore!: Remove artifact path-only logging #3159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!rebuild |
|
The 3.10 pylint job is failing because we don't have the CI fully set up for that yet 😕 |
conradoverta
approved these changes
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact and Context
Since our implementation of untrusted artifact paths in March (#2927), the backend rejects the client's artifact path and substitutes its own. This breaks
ExperimentRun'slog_artifact_path()andlog_image_path(), and it would be a significant undertaking to re-enable that functionality. This PR removes the methods from our API.Risks and Area of Effect
These APIs will no longer be available through the client, though they also have not been operational at all since early this year.
Testing
A search of the client source and tests for
\.log[_a-z]+_pathconfirms that it has been removed completely.How to Revert
Revert this PR.