chore: Remove endpoint date_updated #3711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuverta
commented
Mar 30, 2023
Comment on lines
-129
to
-130
| def _date_updated(self, data): | ||
| return data["date_updated"] |
There was a problem hiding this comment.
I searched the codebase for \._date_updated and it was only being used in this module, below.
| @@ -202,7 +201,7 @@ def _get_by_id(cls, conn, conf, workspace, id): | |||
|
|
|||
| def _get_info_list_by_id(self): | |||
There was a problem hiding this comment.
I searched the codebase for \._get_info_list_by_id and it's only being used in _cli/deployment/list.py.
| table_data = [["PATH", "ID", "DATE UPDATED"]] + list( | ||
| table_data = [["PATH", "ID", "DATE CREATED"]] + list( |
There was a problem hiding this comment.
Now:
% verta deployment list endpoint
got VERTA_HOST from environment
got VERTA_EMAIL from environment
got VERTA_DEV_KEY from environment
connection successfully established
PATH ID DATE CREATED
/simple-deploy 1 2023-03-29T20:52:42.000Z
liuverta
commented
Mar 30, 2023
Comment on lines
-98
to
+109
| assert "path: {}".format(endpoint.path) in result.output | ||
| assert "id: {}".format(endpoint.id) in result.output | ||
| assert "curl: <endpoint not deployed>" in result.output | ||
|
|
||
| assert "status" in result.output | ||
| assert "date created" in result.output | ||
| assert "date updated" in result.output | ||
| assert "stage's date created" in result.output | ||
| assert "stage's date updated" in result.output | ||
| assert "components" in result.output | ||
|
|
||
| updated_status = endpoint.update(experiment_run, DirectUpdateStrategy(), True) | ||
|
|
||
| def in_output(s: str) -> bool: | ||
| return any(line.startswith(s) for line in result.output.splitlines()) | ||
|
|
||
| assert in_output(f"path: {endpoint.path}") | ||
| assert in_output(f"id: {endpoint.id}") | ||
| assert in_output("curl: <endpoint not deployed>") | ||
| assert in_output("status") | ||
| assert in_output("date created") | ||
| assert in_output("stage's date created") | ||
| assert in_output("stage's date updated") | ||
| assert in_output("components") |
There was a problem hiding this comment.
In this test (and the other test), I'm just
- defining a closure to check the output using
str.startswith()instead ofin - using f-strings
- removing
"date updated"
ewagner-verta
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact and Context
It currently provides no user-facing value [Slack].
Risks and Area of Effect
Low; I'm skeptical anyone was even paying it any mind through the client.
Testing
Oops not a unit test, but
Reverting