New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove endpoint date_updated #3711
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -28,7 +28,7 @@ def lst_endpoint(workspace): | |
endpoints = client.endpoints | ||
if workspace: | ||
endpoints = endpoints.with_workspace(workspace) | ||
table_data = [["PATH", "ID", "DATE UPDATED"]] + list( | ||
table_data = [["PATH", "ID", "DATE CREATED"]] + list( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Now: % verta deployment list endpoint
got VERTA_HOST from environment
got VERTA_EMAIL from environment
got VERTA_DEV_KEY from environment
connection successfully established
PATH ID DATE CREATED
/simple-deploy 1 2023-03-29T20:52:42.000Z
|
||
sorted( | ||
map(lambda endpoint: endpoint._get_info_list_by_id(), endpoints), | ||
key=lambda data: data[0], | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -76,7 +76,6 @@ def __repr__(self): | |
"status: {}".format(status["status"]), | ||
"Kafka settings: {}".format(self.kafka_settings), | ||
"date created: {}".format(data["date_created"]), | ||
"date updated: {}".format(data["date_updated"]), | ||
"stage's date created: {}".format(status["date_created"]), | ||
"stage's date updated: {}".format(status["date_updated"]), | ||
"components: {}".format(json.dumps(status["components"], indent=4)), | ||
|
@@ -126,8 +125,8 @@ def get_current_build(self): | |
def _path(self, data): | ||
return data["creator_request"]["path"] | ||
|
||
def _date_updated(self, data): | ||
return data["date_updated"] | ||
Comment on lines
-129
to
-130
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I searched the codebase for |
||
def _date_created(self, data): | ||
return data["date_created"] | ||
|
||
@classmethod | ||
def _create( | ||
|
@@ -202,7 +201,7 @@ def _get_by_id(cls, conn, conf, workspace, id): | |
|
||
def _get_info_list_by_id(self): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I searched the codebase for |
||
data = Endpoint._get_json_by_id(self._conn, self.workspace, self.id) | ||
return [self._path(data), str(self.id), self._date_updated(data)] | ||
return [self._path(data), str(self.id), self._date_created(data)] | ||
|
||
@classmethod | ||
def _get_json_by_id(cls, conn, workspace, id): | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this test (and the other test), I'm just
str.startswith()
instead ofin
"date updated"