Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix diff error on older blobs #432

Merged
merged 2 commits into from
Mar 27, 2020
Merged

fix diff error on older blobs #432

merged 2 commits into from
Mar 27, 2020

Conversation

ravishetye
Copy link

@ravishetye ravishetye commented Mar 27, 2020

the sha computation code extracted from #342 (mainly because it is off feature branch, and will require unnecessary merge resolutions, and secondly it had a small chqnage yet to be made). Thanks @evgeniilezhnin for the original code.

@ravishetye ravishetye merged commit 64f319f into master Mar 27, 2020
@ravishetye ravishetye deleted the rs/diffConflict branch March 27, 2020 23:49
@ravishetye
Copy link
Author

@evgeniilezhnin : please review and have a follow up if there is a better way to handle this.

Copy link
Contributor

@evgeniilezhnin evgeniilezhnin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants