feat(dart_frog_dev): add host option to dart frog dev

VeryGoodOpenSource · Oct 17, 2023 · 1b38183 · 1b38183
1 parent 7b67791
commit 1b38183
Show file tree

Hide file tree

Showing 3 changed files with 43 additions and 2 deletions.
diff --git a/bricks/dart_frog_dev_server/__brick__/server.dart b/bricks/dart_frog_dev_server/__brick__/server.dart
diff --git a/bricks/dart_frog_dev_server/hooks/pre_gen.dart b/bricks/dart_frog_dev_server/hooks/pre_gen.dart
@@ -56,6 +56,7 @@ Future<void> preGen(
   );
 
   context.vars = {
+    'host': context.vars['host'] ?? '',
     'port': context.vars['port'] ?? '8080',
     'directories': configuration.directories
         .map((c) => c.toJson())

diff --git a/bricks/dart_frog_dev_server/hooks/test/pre_gen_test.dart b/bricks/dart_frog_dev_server/hooks/test/pre_gen_test.dart
@@ -162,6 +162,43 @@ void main() {
         equals(
           {
             'port': customPort,
+            'host': '',
+            'directories': <RouteDirectory>[],
+            'routes': <RouteFile>[],
+            'middleware': <MiddlewareFile>[],
+            'globalMiddleware': false,
+            'serveStaticFiles': false,
+            'invokeCustomEntrypoint': false,
+            'invokeCustomInit': false,
+          },
+        ),
+      );
+    });
+
+    test('retains custom host if specified', () async {
+      const customHost = '192.168.1.2';
+      context.vars['host'] = customHost;
+      const configuration = RouteConfiguration(
+        middleware: [],
+        directories: [],
+        routes: [],
+        rogueRoutes: [],
+        endpoints: {},
+      );
+      final exitCalls = <int>[];
+      await preGen(
+        context,
+        buildConfiguration: (_) => configuration,
+        exit: exitCalls.add,
+      );
+      expect(exitCalls, isEmpty);
+      verifyNever(() => logger.err(any()));
+      expect(
+        context.vars,
+        equals(
+          {
+            'port': '8080',
+            'host': '192.168.1.2',
             'directories': <RouteDirectory>[],
             'routes': <RouteFile>[],
             'middleware': <MiddlewareFile>[],
@@ -198,6 +235,7 @@ void main() {
         equals(
           {
             'port': customPort,
+            'host': '',
             'directories': <RouteDirectory>[],
             'routes': <RouteFile>[],
             'middleware': <MiddlewareFile>[],
@@ -234,6 +272,7 @@ void main() {
         equals(
           {
             'port': customPort,
+            'host': '',
             'directories': <RouteDirectory>[],
             'routes': <RouteFile>[],
             'middleware': <MiddlewareFile>[],
@@ -335,6 +374,7 @@ void main() {
         equals(
           {
             'port': '8080',
+            'host': '',
             'directories': [
               {
                 'name': '_',