fix(dart_frog_gen): static dir inside dynamic dir #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renancaraujo
force-pushed
the
renan/fix-nesting-routes
branch
from
c97cd0d
to
e61a67e
Compare
renancaraujo
force-pushed
the
renan/fix-nesting-routes
branch
from
e61a67e
to
2c69c99
Compare
wolfenrain
reviewed
Jul 4, 2022
felangel
reviewed
Jul 4, 2022
packages/dart_frog_gen/test/src/build_route_configuration_test.dart
Outdated
Show resolved
Hide resolved
renancaraujo
force-pushed
the
renan/fix-nesting-routes
branch
from
108fb0c
to
eb0958f
Compare
….dart Co-authored-by: Felix Angelov <felangelov@gmail.com>
renancaraujo
force-pushed
the
renan/fix-nesting-routes
branch
from
eb0958f
to
0b65c83
Compare
felangel
reviewed
Jul 4, 2022
| r'_$user_item_index', | ||
| 'path': '../test/.fixtures/static_dynamic_nested/routes/' | ||
| '[user]/item/index.dart', | ||
| 'route': '/item/<user>' |
There was a problem hiding this comment.
shouldn't this be /<user>/item?
felangel
suggested changes
Jul 4, 2022
|
I opened #138 to address this. lmk what you think |
|
Closing since this should be fixed in #138 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
It was reported on #134 that the generator doesn't recognize routes under directories in the following relationship:
This changes the generator to verify for files inside non-dynamic directories that are inside dynamic directories.
Type of Change