Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dart_frog_cli): add dart_frog_new_brick (middleware implementation) #624

Merged
merged 5 commits into from
May 16, 2023
Merged

feat(dart_frog_cli): add dart_frog_new_brick (middleware implementation) #624

merged 5 commits into from
May 16, 2023

Conversation

renancaraujo
Copy link
Contributor

@renancaraujo renancaraujo commented Apr 27, 2023 •
edited
Loading

Status

READY

Description

Continuation of #623
ref: #260

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@renancaraujo renancaraujo marked this pull request as draft April 27, 2023 15:43
@renancaraujo renancaraujo mentioned this pull request Apr 27, 2023
Merged
7 tasks
@renancaraujo renancaraujo self-assigned this Apr 27, 2023
@renancaraujo renancaraujo force-pushed the renan/dart_frog_new_brick_middleware branch from 1f191be to f0acd83 Compare May 3, 2023 10:50
@renancaraujo renancaraujo force-pushed the renan/dart_frog_new_brick branch 2 times, most recently from e156e71 to 8a1bc2e Compare May 10, 2023 14:45
@renancaraujo renancaraujo force-pushed the renan/dart_frog_new_brick_middleware branch from f0acd83 to 9a580a4 Compare May 10, 2023 14:48
@renancaraujo renancaraujo force-pushed the renan/dart_frog_new_brick branch 3 times, most recently from 2bdcba8 to 0a277e4 Compare May 10, 2023 16:53
@renancaraujo renancaraujo force-pushed the renan/dart_frog_new_brick_middleware branch from 9a580a4 to fa7ea9b Compare May 10, 2023 17:06
@renancaraujo renancaraujo marked this pull request as ready for review May 10, 2023 17:07
@renancaraujo renancaraujo force-pushed the renan/dart_frog_new_brick_middleware branch from fa7ea9b to 301b127 Compare May 10, 2023 17:50
@renancaraujo renancaraujo marked this pull request as draft May 10, 2023 17:55
@renancaraujo renancaraujo marked this pull request as ready for review May 11, 2023 15:43
@renancaraujo renancaraujo marked this pull request as draft May 11, 2023 15:43
@renancaraujo renancaraujo force-pushed the renan/dart_frog_new_brick_middleware branch from 301b127 to 5410054 Compare May 11, 2023 15:51
@renancaraujo renancaraujo force-pushed the renan/dart_frog_new_brick_middleware branch from 5410054 to c3f3575 Compare May 12, 2023 15:40
Base automatically changed from renan/dart_frog_new_brick to main May 12, 2023 15:52
@renancaraujo renancaraujo force-pushed the renan/dart_frog_new_brick_middleware branch from c3f3575 to c8f57bd Compare May 12, 2023 15:52
@renancaraujo renancaraujo marked this pull request as ready for review May 12, 2023 15:53
@renancaraujo @felangel
Update bricks/dart_frog_new/__brick__/{{~ middleware.dart }}
8d336da 
Co-authored-by: Felix Angelov <felangelov@gmail.com>
@renancaraujo renancaraujo force-pushed the renan/dart_frog_new_brick_middleware branch 2 times, most recently from 50ec9ec to edddff3 Compare May 12, 2023 16:37
@renancaraujo renancaraujo force-pushed the renan/dart_frog_new_brick_middleware branch from edddff3 to 95aba24 Compare May 12, 2023 16:44
@renancaraujo renancaraujo merged commit f10004e into main May 16, 2023
4 checks passed
@renancaraujo renancaraujo deleted the renan/dart_frog_new_brick_middleware branch May 16, 2023 12:21
@renancaraujo renancaraujo restored the renan/dart_frog_new_brick_middleware branch May 16, 2023 12:28
@renancaraujo renancaraujo deleted the renan/dart_frog_new_brick_middleware branch May 16, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alestiago alestiago alestiago approved these changes

@wolfenrain wolfenrain Awaiting requested review from wolfenrain

@erickzanardo erickzanardo Awaiting requested review from erickzanardo

@felangel felangel Awaiting requested review from felangel

Assignees

@renancaraujo renancaraujo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@renancaraujo @felangel @alestiago