feat: adding dart_frog_auth package. #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erickzanardo
requested review from
felangel,
renancaraujo and
wolfenrain
as code owners
renancaraujo
approved these changes
Jun 16, 2023
alestiago
reviewed
Jun 18, 2023
erickzanardo
commented
Jun 19, 2023
| .use( | ||
| bearerTokenAuthentication<User>( | ||
| userFromToken: userRepository.fetchFromAccessToken, | ||
| ).build(), |
renancaraujo
approved these changes
Jun 19, 2023
alestiago
approved these changes
Jun 20, 2023
There was a problem hiding this comment.
LGTM 🎉
I very much prefer the new functional approach over the object oriented one, it fits more with the framework.
The example in the README is great, loved it! I think we should (in the future) consider making a tutorial in the docs and pointing to it instead of including it within the README.
Thank you for the contribution 💙
Co-authored-by: Alejandro Santiago <dev@alestiago.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
N DEVELOPMENT
Description
Adds a dart_frog_auth package in order to implement some basic auth methods.
Opening as draft to gather initial feedback
Type of Change