feat: allowing routes to be filtered and adding basic example #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erickzanardo
requested review from
felangel,
renancaraujo and
wolfenrain
as code owners
alestiago
reviewed
Jun 22, 2023
alestiago
reviewed
Jun 23, 2023
examples/basic_authentication/test/lib/user_repostiroy_test.dart
Outdated
Show resolved
Hide resolved
examples/basic_authentication/test/lib/user_repostiroy_test.dart
Outdated
Show resolved
Hide resolved
Co-authored-by: Scarlett Eliza <scarletteliza@gmail.com>
Co-authored-by: Scarlett Eliza <scarletteliza@gmail.com>
Co-authored-by: Alejandro Santiago <dev@alestiago.com>
Co-authored-by: Scarlett Eliza <scarletteliza@gmail.com>
Co-authored-by: Scarlett Eliza <scarletteliza@gmail.com>
Co-authored-by: Scarlett Eliza <scarletteliza@gmail.com>
Co-authored-by: Scarlett Eliza <scarletteliza@gmail.com>
Co-authored-by: Alejandro Santiago <dev@alestiago.com>
renancaraujo
previously approved these changes
Jun 23, 2023
renancaraujo
previously approved these changes
Jun 27, 2023
alestiago
previously approved these changes
Jun 27, 2023
Co-authored-by: Alejandro Santiago <dev@alestiago.com>
erickzanardo
dismissed stale reviews from alestiago and renancaraujo
via
44940b1
Co-authored-by: Alejandro Santiago <dev@alestiago.com>
Co-authored-by: Alejandro Santiago <dev@alestiago.com>
Co-authored-by: Renan <6718144+renancaraujo@users.noreply.github.com>
wolfenrain
reviewed
Jun 30, 2023
Co-authored-by: Jochum van der Ploeg <jochum.vanderploeg@verygood.ventures>
wolfenrain
approved these changes
Jun 30, 2023
renancaraujo
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
This PR adds a complete basic authentication example.
While developing the example, I noticed that it was impossible to make a resource that had authenticated methods, while also having unauthenticated ones, which makes sense thinking in a
usersresource, where thePOST /users, which would be the "register" endpoint, needs to allow unauthenticated calls as an user does not exists yet.So this PR also bundles a proposal for such feature.
Type of Change