Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vscode): normalizing middleware parent as route path #835

Merged
merged 5 commits into from Aug 1, 2023

Conversation

alestiago
Copy link
Contributor

@alestiago alestiago commented Jul 31, 2023

Status

READY

Description

Instead of pre-filling with _middleware when creating a new route it now pre-fills with the middleware parent path.

Before, creating a new route from routes/animals/_middleware would pre-fill the route name field routes/animals/_middleware/. Now, we pre-fill to routes/animals/ which makes more logical sense.

In addition, this also disallows creating middleware of middleware from the context menu since the middleware will already exist.

Demonstration

CleanShot.2023-07-31.at.21.52.21.mp4

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@alestiago alestiago self-assigned this Jul 31, 2023
@alestiago alestiago marked this pull request as draft July 31, 2023 20:46
@alestiago alestiago marked this pull request as ready for review July 31, 2023 20:53
@alestiago alestiago changed the title feat(vscode): normalizing middleware directory as route path feat(vscode): normalizing middleware parent as route path Jul 31, 2023
@alestiago alestiago merged commit 67220e3 into main Aug 1, 2023
4 checks passed
@alestiago alestiago deleted the alestiago/vscode-remove-parsing-middleware-as-route branch August 1, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants