test(vscode): use stub.resolves over stub.returns with Promise #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alestiago
added
test
alestiago
requested review from
felangel,
renancaraujo,
wolfenrain and
erickzanardo
as code owners
erickzanardo
previously approved these changes
Aug 3, 2023
extensions/vscode/src/test/suite/commands/new-middleware.test.ts
Outdated
Show resolved
Hide resolved
extensions/vscode/src/test/suite/commands/new-middleware.test.ts
Outdated
Show resolved
Hide resolved
wolfenrain
previously approved these changes
Aug 3, 2023
erickzanardo
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
Using
stub.resolves(foo)(since it causes the stub to return a Promise which resolves to the provided value) instead ofstub.returns(Promise(foo).Changes:
stub.return(Promise(foo))withstub.resolves(foo)Additional context
Type of Change