Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(vscode): use string over String #865

Merged
merged 3 commits into from Aug 2, 2023

Conversation

alestiago
Copy link
Contributor

Status

READY

Description

When creating a string using foo = "bar" the type of foo is string. In most cases there is no need to use String as the VS Code API accepts string primitives.

See TypeScript Documentation, which does not recommend the use of String:

Don’t ever use the types Number, String, Boolean, Symbol, or Object These types refer to non-primitive boxed objects that are almost never used appropriately in JavaScript code.

Changes:

  • Replaces occurrences of "String" with "string"

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@alestiago alestiago added the refactor A code change that neither fixes a bug nor add a feature label Aug 2, 2023
@alestiago alestiago self-assigned this Aug 2, 2023
@alestiago alestiago merged commit 114cdd3 into main Aug 2, 2023
4 checks passed
@alestiago alestiago deleted the alestiago/refactor-use-string-primitive branch August 2, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor A code change that neither fixes a bug nor add a feature
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants