feat(vscode): define singleton DartFrogDeamon #917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alestiago
requested review from
felangel,
renancaraujo,
wolfenrain and
erickzanardo
as code owners
wolfenrain
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
Defines a
DartFrogDeamonsingleton. TheDartFrogDeamonwill have methods to send and listen to messages (in upcoming PR) to the running process and more.The singleton will be used to access it upon command calls made by the user of the extension since it isn't possible to inject it through on user calls (such as a call from the command palette).
In addition, only a single
DartFrogDeamonis only ever needed, since it can support multiple Dart Frog projects.Type of Change