Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(vscode): allow starting development server #952

Merged
merged 46 commits into from Aug 23, 2023
Merged

feat(vscode): allow starting development server #952

merged 46 commits into from Aug 23, 2023

Conversation

alestiago
Copy link
Contributor

@alestiago alestiago commented Aug 22, 2023 •
edited

Status

READY

Description

Allows starting a development server via the command palette.

Changes:

  • Registers start-dev-server command

Demonstration

CleanShot.2023-08-22.at.09.32.02.mp4

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@alestiago alestiago self-assigned this Aug 22, 2023
@alestiago
test: included suggesting CLI installation tests
71aeb69
@alestiago
test: included confirmation tests
9fcde40
@alestiago
test: does not show confirmation
42f8761
@alestiago
test: ask for port number
bf0316e
@alestiago
test: asks for Dart VM service port number
99b2b0e
@alestiago
test: port validation function
b2452c2
@alestiago
test: refactoring groups and names
422de1f
@alestiago
test: failed to find a Dart Frog project error message
c234967
@alestiago
refactor: removed log
a384433
@alestiago
test: validateInput based on call args
0232c35
@alestiago
test: added correct validation
282c854
@alestiago
test: validateInput for dart vm port
2f2ea94
@alestiago
test: sends start request
e966c88
@alestiago
test: is shown when starting server
2bdac84
@alestiago
refactor: used daemon over dartFrogDaemon
40f27f1
@alestiago
test[wip]: reports error when sever fails to start
ada8c44
@alestiago
test: reports error when server fails to start
6212250
@alestiago
test: does not send start request
70234af
@alestiago
test: refactor beforeEach statements
74c826e
@alestiago
test: finished testing
99d09bf
@alestiago
refactor: removed logs
f5787d2
@alestiago
docs: startDevServer documentation
b180980
@alestiago
docs: startDevServer docs
9eb3903
@alestiago
refactor: renamed to promptForPortNumber
47df4f2
@alestiago alestiago marked this pull request as ready for review August 23, 2023 08:54
@alestiago alestiago merged commit a04ba06 into main Aug 23, 2023
4 checks passed
@alestiago alestiago deleted the alestiago/vscode-start-development-server branch August 23, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfenrain wolfenrain wolfenrain approved these changes

@felangel felangel Awaiting requested review from felangel

@renancaraujo renancaraujo Awaiting requested review from renancaraujo

@erickzanardo erickzanardo Awaiting requested review from erickzanardo

Assignees

@alestiago alestiago

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alestiago @wolfenrain