Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(example): update validation to report empty values #100

Merged
merged 2 commits into from Sep 7, 2023
Merged

fix(example): update validation to report empty values #100

merged 2 commits into from Sep 7, 2023

Conversation

alestiago
Copy link
Contributor

@alestiago alestiago commented Sep 7, 2023 •
edited

Description

Resolves #95

Changes:

  • Uses validator result to report error (instead of display error which ignores Pure fields)
  • Adds empty error to provide user feedback instead when submitting empty values

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@alestiago alestiago added the bug Something isn't working as expected label Sep 7, 2023
@alestiago alestiago self-assigned this Sep 7, 2023
@renancaraujo renancaraujo merged commit d6252b9 into main Sep 7, 2023
4 checks passed
@renancaraujo renancaraujo deleted the alestiago/update-example-empty-values branch September 7, 2023 12:42
@renancaraujo renancaraujo mentioned this pull request Sep 19, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renancaraujo renancaraujo renancaraujo approved these changes

@felangel felangel Awaiting requested review from felangel

@wolfenrain wolfenrain Awaiting requested review from wolfenrain

Assignees

@alestiago alestiago

Labels
bug Something isn't working as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

example/lib/main.dart
2 participants
@alestiago @renancaraujo