feat: add purety check to FormzMixin #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Toavina23
requested review from
felangel,
renancaraujo and
wolfenrain
as code owners
renancaraujo
previously approved these changes
Mar 17, 2023
alestiago
reviewed
Mar 21, 2023
Co-authored-by: Alejandro Santiago <dev@alestiago.com>
Co-authored-by: Alejandro Santiago <dev@alestiago.com>
Co-authored-by: Alejandro Santiago <dev@alestiago.com>
|
thanks for the suggestions, I'll pay more attention next time |
renancaraujo
approved these changes
Mar 21, 2023
alestiago
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added two methods to the FormzMixin for checking the embedded inputs purety, as requested in #82 as well as the tests that covers them.
Type of Change