-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Formz validator now allows async validation #93
feat: Formz validator now allows async validation #93
Conversation
Any updates regarding this? |
I don't know if this is the right approach to do it, I opened the PR to start the discussion with the guys from VGV, but they didn't leave any comment yet |
Adding reference to the issue here: #15 |
I would love to implement this one, I'm just waiting the review guys |
@gabrielchaves7 it looks like there is a merge conflict. Can you please resolve? |
@tomarra @alestiago Just fixed the conflicts, sorry for the delay >_< |
All checks passing, can someone take a look? |
Thanks for the contribution @gabrielchaves7 💙. I would like to give it a look. However, you'll have to bear with me a bit. Sorry for the delay. cc: @wolfenrain , @renancaraujo |
don't worry, feel free to point anything |
@alestiago Can you review again? |
Thanks for the review @alestiago really appreciate it :) |
What are the next steps here? |
Hi! Me and @alestiago just had a look at the PR and I think we need re-evaluate the solution of the PR's goal. I do think that async validation is a necessity but we need to think about how we will introduce this with as little as possible breaking changes both in the API and the scenarios. |
|
If anything we would prefer to prevent any breaking changes, which might mean we just need to provide a new API on top of the existing that is async ready, assuming we can make that work use-cases such as using the Formz is simple enough that people can use it in versatile ways and we would love to ensure that we dont break that simplicity which requires us to evaluate our options, so all I can say right now is that we do want to provide async validation. If you (or anyone else) want/need it right now you can always make an API on top of Formz that is asynchronous. That is also the beauty of Formz. |
Hi @gabrielchaves7 looking to get your feedback here as we are attempting to cleanup open PR's across our packages. Given the last comment from @wolfenrain is this something you plan on still pursuing? |
Right now I don't intend to move on with this PR. If I come up with any implementation that can address @wolfenrain then I will open a new PR. I really appreciated the review you did but I think we did a bad job on scoping. I waste my time and your time just bc we did not discuss the implementation enough before implementing it and I apologize for that |
Description
I've added code to support async form validations.
Initially I just want to bring to discussion on how to do it. Not exactly want the initial PR to be merged.
Type of Change