feat: fixing for Flutter 3.13.0 #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erickzanardo
requested review from
felangel,
renancaraujo and
wolfenrain
as code owners
| class _MockMaterialPageRoute extends MaterialPageRoute<void> { | ||
| _MockMaterialPageRoute({required super.builder}); | ||
|
|
||
| void hackOverlays() { |
There was a problem hiding this comment.
Great!
I spent a good few minutes investigating what could have caused my test to fail after updating to Flutter 3.13.0.
I noticed that without using mockingjay, everything worked as expected (just like in version 3.10.0).
There was a problem hiding this comment.
I create an issue about this, also: #52
There was a problem hiding this comment.
Thanks for the issue @felipecastrosales !!!
wolfenrain
approved these changes
Aug 17, 2023
| _MockMaterialPageRoute({required super.builder}); | ||
|
|
||
| void hackOverlays() { | ||
| for (var i = 0; i < overlayEntries.length; i++) { |
There was a problem hiding this comment.
Is there a way to test this method specifically? I feel it's now accidentally covered
There was a problem hiding this comment.
I feel we don't need any additional tests, since before the change, no test were passing in flutter 3.13
wolfenrain
reviewed
Aug 17, 2023
Co-authored-by: Jochum van der Ploeg <jochum@vdploeg.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It seems that the navigator in Flutter 3.13.0 has changed a little bit how it works internally, those changes broke Mockinjay because how it "hooks" mocks in the navigation made that some internal fields were not populated, breaking the tests when the mocked navigator was disposed.
This PR adds an addition hack in order to trick those unpopulated internal fields so it can start working again.
Type of Change
Fixes #52